From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>,
alan@htj.dyndns.org, linux-ide@vger.kernel.org
Subject: [PATCH] libata: cosmetic change in ata_bus_softreset()
Date: Fri, 24 Mar 2006 12:45:56 +0900 [thread overview]
Message-ID: <20060324034556.GF25706@htj.dyndns.org> (raw)
ata_bus_softreset() should return AC_ERR_* on failure not arbitrary
positive number. While at it, kill trailing indentations and reformat
comment.
Signed-off-by: Tejun Heo <htejun@gmail.com>
diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
index f3c115b..200198c 100644
--- a/drivers/scsi/libata-core.c
+++ b/drivers/scsi/libata-core.c
@@ -1999,13 +1999,12 @@ static unsigned int ata_bus_softreset(st
*/
msleep(150);
-
- /* Before we perform post reset processing we want to see if
- the bus shows 0xFF because the odd clown forgets the D7 pulldown
- resistor */
-
+ /* Before we perform post reset processing we want to see if
+ * the bus shows 0xFF because the odd clown forgets the D7
+ * pulldown resistor
+ */
if (ata_check_status(ap) == 0xFF)
- return 1; /* Positive is failure for some reason */
+ return AC_ERR_OTHER;
ata_bus_post_reset(ap, devmask);
next reply other threads:[~2006-03-24 3:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-03-24 3:45 Tejun Heo [this message]
2006-03-24 14:33 ` [PATCH] libata: cosmetic change in ata_bus_softreset() Jeff Garzik
2006-03-24 16:02 ` [PATCH] libata: cosmetic changes " Tejun Heo
2006-03-24 17:25 ` Jeff Garzik
2006-03-24 17:58 ` Tejun Heo
2006-03-25 4:04 ` Jeff Garzik
2006-03-24 16:33 ` [PATCH] libata: kill E.D.D Tejun Heo
2006-03-24 17:24 ` Jeff Garzik
2006-03-24 18:04 ` Alan Cox
2006-03-24 15:16 ` [PATCH] libata: cosmetic change in ata_bus_softreset() Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060324034556.GF25706@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=alan@htj.dyndns.org \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).