From: Tejun Heo <htejun@gmail.com>
To: Bastiaan Jacques <b.jacques@planet.nl>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH/RFC] ahci: add support for VIA VT8251
Date: Wed, 12 Apr 2006 09:42:32 +0900 [thread overview]
Message-ID: <20060412004232.GA31115@htj.dyndns.org> (raw)
In-Reply-To: <200604111915.45564.b.jacques@planet.nl>
Hello, Bastiaan.
On Tue, Apr 11, 2006 at 07:15:45PM +0200, Bastiaan Jacques wrote:
> +static void ahci_clo(struct ata_port *ap)
> +{
> + void __iomem *port_mmio = (void __iomem *) ap->ioaddr.cmd_addr;
> + u32 tmp;
> +
> + tmp = readl(port_mmio + PORT_CMD);
> + tmp |= PORT_CMD_CLO;
> + writel(tmp, port_mmio + PORT_CMD);
> + readl(port_mmio + PORT_CMD); /* flush */
> +}
Can you please make ahci_clo() check for HOST_CAP_CLO and return
-EOPNOTSUPP (or whatever) if it's not supported?
Thanks.
--
tejun
next prev parent reply other threads:[~2006-04-12 0:42 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-04-11 17:15 [PATCH/RFC] ahci: add support for VIA VT8251 Bastiaan Jacques
2006-04-11 17:41 ` Sergey Vlasov
2006-04-11 20:10 ` Bastiaan Jacques
2006-04-11 22:16 ` Jeff Garzik
2006-04-12 0:42 ` Tejun Heo [this message]
2006-04-12 19:10 ` Bastiaan Jacques
2006-04-12 19:25 ` Jeff Garzik
2006-04-12 20:59 ` Bastiaan Jacques
2006-04-12 21:46 ` Jeff Garzik
2006-04-12 22:19 ` [PATCH 2.6.17-rc1-mm2 1/1] " Bastiaan Jacques
2006-04-12 22:25 ` Bastiaan Jacques
2006-04-12 22:27 ` Jeff Garzik
2006-04-13 0:08 ` Bastiaan Jacques
2006-04-13 3:23 ` Tejun Heo
2006-04-17 12:19 ` [PATCH libata-dev.git upstream " Bastiaan Jacques
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060412004232.GA31115@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=b.jacques@planet.nl \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).