From mboxrd@z Thu Jan 1 00:00:00 1970 From: Andrew Morton Subject: Re: [PATCH] ide_dma_speed() fixes Date: Sun, 14 May 2006 05:05:48 -0700 Message-ID: <20060514050548.5399e3f4.akpm@osdl.org> References: <4463F4C8.9080608@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from smtp.osdl.org ([65.172.181.4]:37860 "EHLO smtp.osdl.org") by vger.kernel.org with ESMTP id S1751404AbWENMJA (ORCPT ); Sun, 14 May 2006 08:09:00 -0400 In-Reply-To: <4463F4C8.9080608@ru.mvista.com> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Sergei Shtylyov Cc: bzolnier@gmail.com, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org Sergei Shtylyov wrote: > > ide_dma_speed() fails to actually honor the IDE drivers' mode support > masks) because of the bogus checks -- thus, selecting the DMA transfer mode > that the driver explicitly refuses to support is possible. Additionally, there > is no check for validity of the UltraDMA mode data in the drive ID, and the > function is misdocumented. drivers/ide/ide-lib.c: In function `ide_dma_speed': drivers/ide/ide-lib.c:86: warning: `ultra_mask' might be used uninitialized in this function Looks like a real bug to me - it depends up on the values of `mode' and id->field_value. Anyway, I'll drop it, please review and fix. I assume that warning was occurring for you as well - please spend more time over these things. Especially when working on IDE, where bugs are slow to show themselves and have particularly bad consequences.