From: Jeff Garzik <jeff@garzik.org>
To: Borislav Petkov <bbpetkov@yahoo.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/n] libata-core.c conversion to new debugging scheme, part 1 (25% done)
Date: Wed, 31 May 2006 02:39:57 -0400 [thread overview]
Message-ID: <20060531063957.GD14179@havoc.gtf.org> (raw)
In-Reply-To: <20060531054633.GA4875@zmei.tnic>
On Wed, May 31, 2006 at 07:46:33AM +0200, Borislav Petkov wrote:
> This patch converts the first 25% of libata-core.c to the new debugging scheme.
>
> Signed-off-by: <petkov@uni-muenster.de>
Looks good at first glance, though I'll hold off on apply until I return
from the Red Hat Summit in Nashville.
It made me remember another point, though: in order to avoid
regressions, after applying your patch, I would think that you would
want to create a patch which did something like
#ifndef ATA_VERBOSE_DEBUG
ap->msg_enable = xxx
#else ATA_DEBUG
ap->msg_enable = yyy
#else
ap->msg_enable = ...
#endif
Thus, we are assured that applying your patch will not change the
behavior(much?) when ATA_VERBOSE_DEBUG is enabled.
Regards,
Jeff
next prev parent reply other threads:[~2006-05-31 6:39 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-05-31 5:46 [PATCH 1/n] libata-core.c conversion to new debugging scheme, part 1 (25% done) Borislav Petkov
2006-05-31 6:39 ` Jeff Garzik [this message]
2006-06-01 5:38 ` Borislav Petkov
2006-06-01 6:09 ` Tejun Heo
2006-06-01 6:14 ` Jeff Garzik
2006-06-02 7:32 ` Borislav Petkov
2006-06-01 6:44 ` Borislav Petkov
2006-06-12 3:11 ` Jeff Garzik
2006-06-12 3:48 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060531063957.GD14179@havoc.gtf.org \
--to=jeff@garzik.org \
--cc=bbpetkov@yahoo.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).