From: Jens Axboe <axboe@suse.de>
To: Hannes Reinecke <hare@suse.de>
Cc: "zhao, forrest" <forrest.zhao@intel.com>,
Jeremy Fitzhardinge <jeremy@goop.org>, Mark Lord <lkml@rtr.ca>,
Jeff Garzik <jeff@garzik.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-ide@vger.kernel.org
Subject: Re: State of resume for AHCI?
Date: Fri, 2 Jun 2006 08:52:06 +0200 [thread overview]
Message-ID: <20060602065206.GV4400@suse.de> (raw)
In-Reply-To: <447FDE2E.5010401@suse.de>
On Fri, Jun 02 2006, Hannes Reinecke wrote:
> Jens Axboe wrote:
> > On Fri, Jun 02 2006, zhao, forrest wrote:
> >> On Fri, 2006-06-02 at 08:03 +0200, Jens Axboe wrote:
> >>> On Thu, Jun 01 2006, Jeremy Fitzhardinge wrote:
> >>>> Jens Axboe wrote:
> >>>>> It's a lot more complicated than that, I'm afraid. ahci doesn't even
> >>>>> have the resume/suspend methods defined, plus it needs more work than
> >>>>> piix on resume.
> >>>>>
> >>>> Hannes Reinecke's patch implements those functions, basically by
> >>>> factoring out the shutdown and init code and calling them at
> >>>> suspend/resume time as well.
> >>>>
> >>>> Is that correct/sufficient? Or should something else be happening?
> >>> No that's it, I know for a fact that suspend/resume works perfectly with
> >>> the 10.1 suse kernel. You can give that a shot, if you want.
> >> You may mean the Hannes's patch for 10.1 SUSE kernel. Hannes's patch
> >> posted in open source community(or in linux-ide mailing list) didn't
> >> work.
> >
> > I didn't say Hannes patch, I said I know that 10.1 works. And that is
> > probably in large due to the patch that Hannes did, which implents
> > resume/suspend and takes care of reinitializing the resources.
> >
> Indeed. I didn't post the latest set of patches to the open-source
> community as Jeff indicated he would only accept patches against
> libata-dev. And as I didn't have time to port them yet I didn't feel the
> need to do so.
Understandable, I hope you will have some time to push it for 2.6.18
though.
--
Jens Axboe
prev parent reply other threads:[~2006-06-02 6:49 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <447F23C2.8030802@goop.org>
[not found] ` <447F3250.5070101@rtr.ca>
[not found] ` <20060601183904.GR4400@suse.de>
2006-06-01 20:19 ` State of resume for AHCI? Jeremy Fitzhardinge
2006-06-02 1:02 ` zhao, forrest
2006-06-02 3:39 ` Jeremy Fitzhardinge
2006-06-02 6:39 ` Hannes Reinecke
2006-06-02 6:03 ` Jens Axboe
2006-06-02 6:03 ` zhao, forrest
2006-06-02 6:41 ` Jens Axboe
2006-06-02 6:43 ` Hannes Reinecke
2006-06-02 6:49 ` zhao, forrest
2006-06-02 7:06 ` Jens Axboe
2006-06-02 6:52 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060602065206.GV4400@suse.de \
--to=axboe@suse.de \
--cc=forrest.zhao@intel.com \
--cc=hare@suse.de \
--cc=jeff@garzik.org \
--cc=jeremy@goop.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=lkml@rtr.ca \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).