From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jens Axboe Subject: Re: State of resume for AHCI? Date: Fri, 2 Jun 2006 08:52:06 +0200 Message-ID: <20060602065206.GV4400@suse.de> References: <447F23C2.8030802@goop.org> <447F3250.5070101@rtr.ca> <20060601183904.GR4400@suse.de> <447F4BC2.8060808@goop.org> <20060602060323.GS4400@suse.de> <1149228204.13451.8.camel@forrest26.sh.intel.com> <20060602064148.GT4400@suse.de> <447FDE2E.5010401@suse.de> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from ns.virtualhost.dk ([195.184.98.160]:26436 "EHLO virtualhost.dk") by vger.kernel.org with ESMTP id S1751223AbWFBGt6 (ORCPT ); Fri, 2 Jun 2006 02:49:58 -0400 Content-Disposition: inline In-Reply-To: <447FDE2E.5010401@suse.de> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Hannes Reinecke Cc: "zhao, forrest" , Jeremy Fitzhardinge , Mark Lord , Jeff Garzik , Linux Kernel Mailing List , linux-ide@vger.kernel.org On Fri, Jun 02 2006, Hannes Reinecke wrote: > Jens Axboe wrote: > > On Fri, Jun 02 2006, zhao, forrest wrote: > >> On Fri, 2006-06-02 at 08:03 +0200, Jens Axboe wrote: > >>> On Thu, Jun 01 2006, Jeremy Fitzhardinge wrote: > >>>> Jens Axboe wrote: > >>>>> It's a lot more complicated than that, I'm afraid. ahci doesn't even > >>>>> have the resume/suspend methods defined, plus it needs more work than > >>>>> piix on resume. > >>>>> > >>>> Hannes Reinecke's patch implements those functions, basically by > >>>> factoring out the shutdown and init code and calling them at > >>>> suspend/resume time as well. > >>>> > >>>> Is that correct/sufficient? Or should something else be happening? > >>> No that's it, I know for a fact that suspend/resume works perfectly with > >>> the 10.1 suse kernel. You can give that a shot, if you want. > >> You may mean the Hannes's patch for 10.1 SUSE kernel. Hannes's patch > >> posted in open source community(or in linux-ide mailing list) didn't > >> work. > > > > I didn't say Hannes patch, I said I know that 10.1 works. And that is > > probably in large due to the patch that Hannes did, which implents > > resume/suspend and takes care of reinitializing the resources. > > > Indeed. I didn't post the latest set of patches to the open-source > community as Jeff indicated he would only accept patches against > libata-dev. And as I didn't have time to port them yet I didn't feel the > need to do so. Understandable, I hope you will have some time to push it for 2.6.18 though. -- Jens Axboe