Re: State of resume for AHCI?

Re: State of resume for AHCI?

[Jeremy Fitzhardinge]

Jens Axboe wrote:
> It's a lot more complicated than that, I'm afraid. ahci doesn't even
> have the resume/suspend methods defined, plus it needs more work than
> piix on resume.
>   
Hannes Reinecke's patch implements those functions, basically by 
factoring out the shutdown and init code and calling them at 
suspend/resume time as well.

Is that correct/sufficient?  Or should something else be happening?

    J

Re: State of resume for AHCI?

[zhao, forrest]

On Thu, 2006-06-01 at 13:19 -0700, Jeremy Fitzhardinge wrote:
> Jens Axboe wrote:
> > It's a lot more complicated than that, I'm afraid. ahci doesn't even
> > have the resume/suspend methods defined, plus it needs more work than
> > piix on resume.
> >   
> Hannes Reinecke's patch implements those functions, basically by 
> factoring out the shutdown and init code and calling them at 
> suspend/resume time as well.
> 
> Is that correct/sufficient?  Or should something else be happening?

According to our test of Hannes's patch, it's not sufficient to support
AHCI suspend/resume.

Now I'm writing a patch to try to provide complete support for AHCI
suspend/resume and will send out patch soon, hopefully by the end of
today.

Thanks,
Forrest

Re: State of resume for AHCI?

[Jeremy Fitzhardinge]

zhao, forrest wrote:
> According to our test of Hannes's patch, it's not sufficient to support
> AHCI suspend/resume.
>   
Yes.  I merged it into mm2, and it didn't make any difference.
> Now I'm writing a patch to try to provide complete support for AHCI
> suspend/resume and will send out patch soon, hopefully by the end of
> today.
Great, looking forward to it.

    J

Re: State of resume for AHCI?

[Hannes Reinecke]

zhao, forrest wrote:
> On Thu, 2006-06-01 at 13:19 -0700, Jeremy Fitzhardinge wrote:
>> Jens Axboe wrote:
>>> It's a lot more complicated than that, I'm afraid. ahci doesn't even
>>> have the resume/suspend methods defined, plus it needs more work than
>>> piix on resume.
>>>   
>> Hannes Reinecke's patch implements those functions, basically by 
>> factoring out the shutdown and init code and calling them at 
>> suspend/resume time as well.
>>
>> Is that correct/sufficient?  Or should something else be happening?
> 
> According to our test of Hannes's patch, it's not sufficient to support
> AHCI suspend/resume.
> 
> Now I'm writing a patch to try to provide complete support for AHCI
> suspend/resume and will send out patch soon, hopefully by the end of
> today.
> 
Can I have details, please? What doesn't work?

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

Re: State of resume for AHCI?

[Jens Axboe]

On Thu, Jun 01 2006, Jeremy Fitzhardinge wrote:
> Jens Axboe wrote:
> >It's a lot more complicated than that, I'm afraid. ahci doesn't even
> >have the resume/suspend methods defined, plus it needs more work than
> >piix on resume.
> >  
> Hannes Reinecke's patch implements those functions, basically by 
> factoring out the shutdown and init code and calling them at 
> suspend/resume time as well.
> 
> Is that correct/sufficient?  Or should something else be happening?

No that's it, I know for a fact that suspend/resume works perfectly with
the 10.1 suse kernel. You can give that a shot, if you want.

-- 
Jens Axboe

Re: State of resume for AHCI?

[zhao, forrest]

On Fri, 2006-06-02 at 08:03 +0200, Jens Axboe wrote:
> On Thu, Jun 01 2006, Jeremy Fitzhardinge wrote:
> > Jens Axboe wrote:
> > >It's a lot more complicated than that, I'm afraid. ahci doesn't even
> > >have the resume/suspend methods defined, plus it needs more work than
> > >piix on resume.
> > >  
> > Hannes Reinecke's patch implements those functions, basically by 
> > factoring out the shutdown and init code and calling them at 
> > suspend/resume time as well.
> > 
> > Is that correct/sufficient?  Or should something else be happening?
> 
> No that's it, I know for a fact that suspend/resume works perfectly with
> the 10.1 suse kernel. You can give that a shot, if you want.

You may mean the Hannes's patch for 10.1 SUSE kernel. Hannes's patch
posted in open source community(or in linux-ide mailing list) didn't
work.

Forrest

Re: State of resume for AHCI?

[Jens Axboe]

On Fri, Jun 02 2006, zhao, forrest wrote:
> On Fri, 2006-06-02 at 08:03 +0200, Jens Axboe wrote:
> > On Thu, Jun 01 2006, Jeremy Fitzhardinge wrote:
> > > Jens Axboe wrote:
> > > >It's a lot more complicated than that, I'm afraid. ahci doesn't even
> > > >have the resume/suspend methods defined, plus it needs more work than
> > > >piix on resume.
> > > >  
> > > Hannes Reinecke's patch implements those functions, basically by 
> > > factoring out the shutdown and init code and calling them at 
> > > suspend/resume time as well.
> > > 
> > > Is that correct/sufficient?  Or should something else be happening?
> > 
> > No that's it, I know for a fact that suspend/resume works perfectly with
> > the 10.1 suse kernel. You can give that a shot, if you want.
> 
> You may mean the Hannes's patch for 10.1 SUSE kernel. Hannes's patch
> posted in open source community(or in linux-ide mailing list) didn't
> work.

I didn't say Hannes patch, I said I know that 10.1 works. And that is
probably in large due to the patch that Hannes did, which implents
resume/suspend and takes care of reinitializing the resources.

-- 
Jens Axboe

Re: State of resume for AHCI?

[Hannes Reinecke]

Jens Axboe wrote:
> On Fri, Jun 02 2006, zhao, forrest wrote:
>> On Fri, 2006-06-02 at 08:03 +0200, Jens Axboe wrote:
>>> On Thu, Jun 01 2006, Jeremy Fitzhardinge wrote:
>>>> Jens Axboe wrote:
>>>>> It's a lot more complicated than that, I'm afraid. ahci doesn't even
>>>>> have the resume/suspend methods defined, plus it needs more work than
>>>>> piix on resume.
>>>>>  
>>>> Hannes Reinecke's patch implements those functions, basically by 
>>>> factoring out the shutdown and init code and calling them at 
>>>> suspend/resume time as well.
>>>>
>>>> Is that correct/sufficient?  Or should something else be happening?
>>> No that's it, I know for a fact that suspend/resume works perfectly with
>>> the 10.1 suse kernel. You can give that a shot, if you want.
>> You may mean the Hannes's patch for 10.1 SUSE kernel. Hannes's patch
>> posted in open source community(or in linux-ide mailing list) didn't
>> work.
> 
> I didn't say Hannes patch, I said I know that 10.1 works. And that is
> probably in large due to the patch that Hannes did, which implents
> resume/suspend and takes care of reinitializing the resources.
> 
Indeed. I didn't post the latest set of patches to the open-source
community as Jeff indicated he would only accept patches against
libata-dev. And as I didn't have time to port them yet I didn't feel the
need to do so.

Forrest, please drop me a mail if I can be of further assistance.

Cheers,

Hannes
-- 
Dr. Hannes Reinecke			hare@suse.de
SuSE Linux Products GmbH		S390 & zSeries
Maxfeldstraße 5				+49 911 74053 688
90409 Nürnberg				http://www.suse.de

Re: State of resume for AHCI?

[zhao, forrest]

On Fri, 2006-06-02 at 08:43 +0200, Hannes Reinecke wrote:
> Jens Axboe wrote:
> > On Fri, Jun 02 2006, zhao, forrest wrote:
> >> On Fri, 2006-06-02 at 08:03 +0200, Jens Axboe wrote:
> >>> On Thu, Jun 01 2006, Jeremy Fitzhardinge wrote:
> >>>> Jens Axboe wrote:
> >>>>> It's a lot more complicated than that, I'm afraid. ahci doesn't even
> >>>>> have the resume/suspend methods defined, plus it needs more work than
> >>>>> piix on resume.
> >>>>>  
> >>>> Hannes Reinecke's patch implements those functions, basically by 
> >>>> factoring out the shutdown and init code and calling them at 
> >>>> suspend/resume time as well.
> >>>>
> >>>> Is that correct/sufficient?  Or should something else be happening?
> >>> No that's it, I know for a fact that suspend/resume works perfectly with
> >>> the 10.1 suse kernel. You can give that a shot, if you want.
> >> You may mean the Hannes's patch for 10.1 SUSE kernel. Hannes's patch
> >> posted in open source community(or in linux-ide mailing list) didn't
> >> work.
> > 
> > I didn't say Hannes patch, I said I know that 10.1 works. And that is
> > probably in large due to the patch that Hannes did, which implents
> > resume/suspend and takes care of reinitializing the resources.
> > 
> Indeed. I didn't post the latest set of patches to the open-source
> community as Jeff indicated he would only accept patches against
> libata-dev. And as I didn't have time to port them yet I didn't feel the
> need to do so.
> 
> Forrest, please drop me a mail if I can be of further assistance.

I almost finished porting a patch from OpenSUSE, will send it out in an
hour, please help review it :)

Thanks,
Forrest

Re: State of resume for AHCI?

[Jens Axboe]

On Fri, Jun 02 2006, zhao, forrest wrote:
> On Fri, 2006-06-02 at 08:43 +0200, Hannes Reinecke wrote:
> > Jens Axboe wrote:
> > > On Fri, Jun 02 2006, zhao, forrest wrote:
> > >> On Fri, 2006-06-02 at 08:03 +0200, Jens Axboe wrote:
> > >>> On Thu, Jun 01 2006, Jeremy Fitzhardinge wrote:
> > >>>> Jens Axboe wrote:
> > >>>>> It's a lot more complicated than that, I'm afraid. ahci doesn't even
> > >>>>> have the resume/suspend methods defined, plus it needs more work than
> > >>>>> piix on resume.
> > >>>>>  
> > >>>> Hannes Reinecke's patch implements those functions, basically by 
> > >>>> factoring out the shutdown and init code and calling them at 
> > >>>> suspend/resume time as well.
> > >>>>
> > >>>> Is that correct/sufficient?  Or should something else be happening?
> > >>> No that's it, I know for a fact that suspend/resume works perfectly with
> > >>> the 10.1 suse kernel. You can give that a shot, if you want.
> > >> You may mean the Hannes's patch for 10.1 SUSE kernel. Hannes's patch
> > >> posted in open source community(or in linux-ide mailing list) didn't
> > >> work.
> > > 
> > > I didn't say Hannes patch, I said I know that 10.1 works. And that is
> > > probably in large due to the patch that Hannes did, which implents
> > > resume/suspend and takes care of reinitializing the resources.
> > > 
> > Indeed. I didn't post the latest set of patches to the open-source
> > community as Jeff indicated he would only accept patches against
> > libata-dev. And as I didn't have time to port them yet I didn't feel the
> > need to do so.
> > 
> > Forrest, please drop me a mail if I can be of further assistance.
> 
> I almost finished porting a patch from OpenSUSE, will send it out in an
> hour, please help review it :)

Wonderful! Please do test it as well :-)

-- 
Jens Axboe

Re: State of resume for AHCI?

[Jens Axboe]

On Fri, Jun 02 2006, Hannes Reinecke wrote:
> Jens Axboe wrote:
> > On Fri, Jun 02 2006, zhao, forrest wrote:
> >> On Fri, 2006-06-02 at 08:03 +0200, Jens Axboe wrote:
> >>> On Thu, Jun 01 2006, Jeremy Fitzhardinge wrote:
> >>>> Jens Axboe wrote:
> >>>>> It's a lot more complicated than that, I'm afraid. ahci doesn't even
> >>>>> have the resume/suspend methods defined, plus it needs more work than
> >>>>> piix on resume.
> >>>>>  
> >>>> Hannes Reinecke's patch implements those functions, basically by 
> >>>> factoring out the shutdown and init code and calling them at 
> >>>> suspend/resume time as well.
> >>>>
> >>>> Is that correct/sufficient?  Or should something else be happening?
> >>> No that's it, I know for a fact that suspend/resume works perfectly with
> >>> the 10.1 suse kernel. You can give that a shot, if you want.
> >> You may mean the Hannes's patch for 10.1 SUSE kernel. Hannes's patch
> >> posted in open source community(or in linux-ide mailing list) didn't
> >> work.
> > 
> > I didn't say Hannes patch, I said I know that 10.1 works. And that is
> > probably in large due to the patch that Hannes did, which implents
> > resume/suspend and takes care of reinitializing the resources.
> > 
> Indeed. I didn't post the latest set of patches to the open-source
> community as Jeff indicated he would only accept patches against
> libata-dev. And as I didn't have time to port them yet I didn't feel the
> need to do so.

Understandable, I hope you will have some time to push it for 2.6.18
though.

-- 
Jens Axboe