From: Tejun Heo <htejun@gmail.com>
To: jeff@garzik.org
Cc: boac@wanadoo.nl, b.jacques@planet.nl, linux-ide@vger.kernel.org
Subject: [PATCH] ahci: disable NCQ support on vt8251
Date: Wed, 21 Jun 2006 23:12:48 +0900 [thread overview]
Message-ID: <20060621141248.GA22805@htj.dyndns.org> (raw)
In-Reply-To: <200606202131.12654.b.jacques@planet.nl>
vt8251 chokes on NCQ commands. Two different disks from different
vendors are showing the same symptom and it seems that the windows
driver from via doesn't support NCQ either. Disable NCQ support on
this controller for the time being.
Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Aalderd Bouwman <boac@wanadoo.nl>
Cc: Bastiaan Jacques <b.jacques@planet.nl>
---
diff --git a/drivers/scsi/ahci.c b/drivers/scsi/ahci.c
index e261b37..8208546 100644
--- a/drivers/scsi/ahci.c
+++ b/drivers/scsi/ahci.c
@@ -164,6 +164,7 @@ enum {
/* ap->flags bits */
AHCI_FLAG_RESET_NEEDS_CLO = (1 << 24),
+ AHCI_FLAG_NO_NCQ = (1 << 25),
};
struct ahci_cmd_hdr {
@@ -277,7 +278,7 @@ static const struct ata_port_info ahci_p
.host_flags = ATA_FLAG_SATA | ATA_FLAG_NO_LEGACY |
ATA_FLAG_MMIO | ATA_FLAG_PIO_DMA |
ATA_FLAG_SKIP_D2H_BSY |
- AHCI_FLAG_RESET_NEEDS_CLO,
+ AHCI_FLAG_RESET_NEEDS_CLO | AHCI_FLAG_NO_NCQ,
.pio_mask = 0x1f, /* pio0-4 */
.udma_mask = 0x7f, /* udma0-6 ; FIXME */
.port_ops = &ahci_ops,
@@ -1362,7 +1363,8 @@ static int ahci_init_one (struct pci_dev
if (rc)
goto err_out_hpriv;
- if (hpriv->cap & HOST_CAP_NCQ)
+ if (!(probe_ent->host_flags & AHCI_FLAG_NO_NCQ) &&
+ (hpriv->cap & HOST_CAP_NCQ))
probe_ent->host_flags |= ATA_FLAG_NCQ;
ahci_print_info(probe_ent);
next prev parent reply other threads:[~2006-06-21 14:12 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-08 17:30 Seagate SATA 3GB/s drive connected to via vt8251 using ahci module Aalderd Bouwman
2006-06-09 5:44 ` Tejun Heo
2006-06-12 10:42 ` Aalderd Bouwman
2006-06-12 10:51 ` Tejun Heo
2006-06-12 11:24 ` Aalderd Bouwman
2006-06-18 2:56 ` Tejun Heo
2006-06-19 17:10 ` Aalderd Bouwman
2006-06-19 17:18 ` Tejun Heo
[not found] ` <1150745738.4302.1.camel@anja>
[not found] ` <20060620023312.GA1250@htj.dyndns.org>
2006-06-20 15:21 ` Aalderd Bouwman
2006-06-20 15:37 ` Tejun Heo
2006-06-20 19:31 ` Bastiaan Jacques
2006-06-21 7:25 ` Aalderd Bouwman
2006-06-21 14:12 ` Tejun Heo [this message]
2006-06-23 3:22 ` [PATCH] ahci: disable NCQ support on vt8251 Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060621141248.GA22805@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=b.jacques@planet.nl \
--cc=boac@wanadoo.nl \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).