* [-mm patch] drivers/ide/legacy/ide-cs.c: make 2 functions static [not found] <20060621034857.35cfe36f.akpm@osdl.org> @ 2006-06-21 21:57 ` Adrian Bunk 2006-06-21 23:20 ` [-mm patch] make drivers/scsi/pata_pcmcia.c:pcmcia_remove_one() static Adrian Bunk 1 sibling, 0 replies; 3+ messages in thread From: Adrian Bunk @ 2006-06-21 21:57 UTC (permalink / raw) To: Andrew Morton, Thomas Kleffel, Dominik Brodowski Cc: linux-kernel, B.Zolnierkiewicz, linux-ide On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote: >... > Changes since 2.6.17-rc6-mm2: >... > git-pcmcia.patch >... > git trees >... This patch makes two needlessly global functions static. Signed-off-by: Adrian Bunk <bunk@stusta.de> --- drivers/ide/legacy/ide-cs.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) --- linux-2.6.17-mm1-full/drivers/ide/legacy/ide-cs.c.old 2006-06-21 22:54:20.000000000 +0200 +++ linux-2.6.17-mm1-full/drivers/ide/legacy/ide-cs.c 2006-06-21 22:54:37.000000000 +0200 @@ -170,11 +170,11 @@ return ide_register_hw_with_fixup(&hw, NULL, ide_undecoded_slave); } -void outb_io(unsigned char value, unsigned long port) { +static void outb_io(unsigned char value, unsigned long port) { outb(value, port); } -void outb_mem(unsigned char value, unsigned long port) { +static void outb_mem(unsigned char value, unsigned long port) { writeb(value, (void __iomem *) port); } ^ permalink raw reply [flat|nested] 3+ messages in thread
* [-mm patch] make drivers/scsi/pata_pcmcia.c:pcmcia_remove_one() static [not found] <20060621034857.35cfe36f.akpm@osdl.org> 2006-06-21 21:57 ` [-mm patch] drivers/ide/legacy/ide-cs.c: make 2 functions static Adrian Bunk @ 2006-06-21 23:20 ` Adrian Bunk 2006-06-22 10:50 ` Alan Cox 1 sibling, 1 reply; 3+ messages in thread From: Adrian Bunk @ 2006-06-21 23:20 UTC (permalink / raw) To: Andrew Morton, alan; +Cc: linux-kernel, jgarzik, linux-ide On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote: >... > Changes since 2.6.17-rc6-mm2: >... > git-libata-all.patch >... > git trees >... This patch makes a needlessly global function static. Signed-off-by: Adrian Bunk <bunk@stusta.de> --- linux-2.6.17-mm1-full/drivers/scsi/pata_pcmcia.c.old 2006-06-22 00:43:23.000000000 +0200 +++ linux-2.6.17-mm1-full/drivers/scsi/pata_pcmcia.c 2006-06-22 00:43:33.000000000 +0200 @@ -294,7 +294,7 @@ * cleanup. Also called on module unload for any active devices. */ -void pcmcia_remove_one(struct pcmcia_device *pdev) +static void pcmcia_remove_one(struct pcmcia_device *pdev) { struct ata_pcmcia_info *info = pdev->priv; struct device *dev = &pdev->dev; ^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [-mm patch] make drivers/scsi/pata_pcmcia.c:pcmcia_remove_one() static 2006-06-21 23:20 ` [-mm patch] make drivers/scsi/pata_pcmcia.c:pcmcia_remove_one() static Adrian Bunk @ 2006-06-22 10:50 ` Alan Cox 0 siblings, 0 replies; 3+ messages in thread From: Alan Cox @ 2006-06-22 10:50 UTC (permalink / raw) To: Adrian Bunk; +Cc: Andrew Morton, alan, linux-kernel, jgarzik, linux-ide On Thu, Jun 22, 2006 at 01:20:12AM +0200, Adrian Bunk wrote: > On Wed, Jun 21, 2006 at 03:48:57AM -0700, Andrew Morton wrote: > >... > > Changes since 2.6.17-rc6-mm2: > >... > > git-libata-all.patch > >... > > git trees > >... > > This patch makes a needlessly global function static. > > Signed-off-by: Adrian Bunk <bunk@stusta.de> Acked-by: Alan Cox <alan@redhat.com> > > --- linux-2.6.17-mm1-full/drivers/scsi/pata_pcmcia.c.old 2006-06-22 00:43:23.000000000 +0200 > +++ linux-2.6.17-mm1-full/drivers/scsi/pata_pcmcia.c 2006-06-22 00:43:33.000000000 +0200 > @@ -294,7 +294,7 @@ > * cleanup. Also called on module unload for any active devices. > */ > > -void pcmcia_remove_one(struct pcmcia_device *pdev) > +static void pcmcia_remove_one(struct pcmcia_device *pdev) > { > struct ata_pcmcia_info *info = pdev->priv; > struct device *dev = &pdev->dev; -- -- In Ximian did mad Miguel a mighty mail client decree Where Nat the crazy hacker ran Through sourcecode measureless to man And never coredump free ^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-06-22 10:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
[not found] <20060621034857.35cfe36f.akpm@osdl.org>
2006-06-21 21:57 ` [-mm patch] drivers/ide/legacy/ide-cs.c: make 2 functions static Adrian Bunk
2006-06-21 23:20 ` [-mm patch] make drivers/scsi/pata_pcmcia.c:pcmcia_remove_one() static Adrian Bunk
2006-06-22 10:50 ` Alan Cox
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox; as well as URLs for NNTP newsgroup(s).