From: Alan Cox <alan@redhat.com>
To: Adrian Bunk <bunk@stusta.de>
Cc: Andrew Morton <akpm@osdl.org>,
alan@redhat.com, linux-kernel@vger.kernel.org, jgarzik@pobox.com,
linux-ide@vger.kernel.org
Subject: Re: [-mm patch] make drivers/scsi/pata_it821x.c:it821x_passthru_dev_select() static
Date: Sun, 25 Jun 2006 19:27:28 -0400 [thread overview]
Message-ID: <20060625232728.GA20345@devserv.devel.redhat.com> (raw)
In-Reply-To: <20060625231324.GK23314@stusta.de>
On Mon, Jun 26, 2006 at 01:13:24AM +0200, Adrian Bunk wrote:
> On Sat, Jun 24, 2006 at 06:19:14AM -0700, Andrew Morton wrote:
> >...
> > Changes since 2.6.17-mm1:
> >...
> > git-libata-all.patch
> >...
> > git trees
> >...
>
> This patch makes the needlessly global it821x_passthru_dev_select()
> static.
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
Acked-by: Alan Cox <alan@redhat.com>
>
> --- linux-2.6.17-mm2-full/drivers/scsi/pata_it821x.c.old 2006-06-25 22:52:11.000000000 +0200
> +++ linux-2.6.17-mm2-full/drivers/scsi/pata_it821x.c 2006-06-25 22:52:52.000000000 +0200
> @@ -411,7 +411,8 @@
> * Device selection hook. If neccessary perform clock switching
> */
>
> -void it821x_passthru_dev_select(struct ata_port *ap, unsigned int device)
> +static void it821x_passthru_dev_select(struct ata_port *ap,
> + unsigned int device)
> {
> struct it821x_dev *itdev = ap->private_data;
> if (itdev && device != itdev->last_device) {
--
"Some people are like Slinkies...
Not really good for anything,
but they still bring a smile to your face
when you push them down a flight of stairs."
-- Gordon Wolfe.
next prev parent reply other threads:[~2006-06-25 23:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20060624061914.202fbfb5.akpm@osdl.org>
2006-06-25 23:13 ` [-mm patch] make drivers/scsi/pata_it821x.c:it821x_passthru_dev_select() static Adrian Bunk
2006-06-25 23:27 ` Alan Cox [this message]
2006-06-27 1:03 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060625232728.GA20345@devserv.devel.redhat.com \
--to=alan@redhat.com \
--cc=akpm@osdl.org \
--cc=bunk@stusta.de \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).