From: Greg KH <gregkh@suse.de>
To: Jeff Garzik <jeff@garzik.org>
Cc: "linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
bcasavan@sgi.com, jes@sgi.com, akpm@osdl.org
Subject: Re: Improving sata_vsc PCI ID usage...
Date: Mon, 26 Jun 2006 21:28:45 -0700 [thread overview]
Message-ID: <20060627042845.GB1768@suse.de> (raw)
In-Reply-To: <44A081D5.80905@garzik.org>
On Mon, Jun 26, 2006 at 08:54:45PM -0400, Jeff Garzik wrote:
> FYI, I just committed the attached patch to libata-dev.git...
>
> Jeff
>
>
> commit 438bc9c3dec27ab37f0ff78471d0b8b91addd2dd
> Author: Jeff Garzik <jeff@garzik.org>
> Date: Mon Jun 26 20:52:17 2006 -0400
>
> [libata] sata_vsc: partially revert a PCI ID-related commit
>
> Partially revert 74d0a988d3aa359b6b8a8536c8cb92cce02ca5d5:
>
> [PATCH] PCI: Move various PCI IDs to header file
>
> libata policy is to avoid use of named PCI device ID constants.
> These are often single-use constants, which have little value over
> direct numeric constants save for constant include/linux/pci_ids.h
> patching/merging headaches.
>
> Signed-off-by: Jeff Garzik <jeff@garzik.org>
Acked-by: Greg Kroah-Hartman <gregkh@suse.de>
prev parent reply other threads:[~2006-06-27 4:30 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-06-27 0:54 Improving sata_vsc PCI ID usage Jeff Garzik
2006-06-27 4:28 ` Greg KH [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060627042845.GB1768@suse.de \
--to=gregkh@suse.de \
--cc=akpm@osdl.org \
--cc=bcasavan@sgi.com \
--cc=jeff@garzik.org \
--cc=jes@sgi.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).