linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Martin Hicks <mort@bork.org>
To: jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: [PATCH] sata_vsc: data_xfer should use mmio
Date: Wed, 28 Jun 2006 12:17:47 -0400	[thread overview]
Message-ID: <20060628161747.GC16658@bork.org> (raw)


Hi,


sata_vsc is an MMIO device, and should use the correct data_xfer
function.  This problem was introduced by:

   commit a6b2c5d4754dc539a560fdf0d3fb78a14174394a
   Author: Alan Cox <alan@lxorguk.ukuu.org.uk>
   Date:   Mon May 22 16:59:59 2006 +0100

        [PATCH] PATCH: libata. Add ->data_xfer method

Signed-off-by: Martin Hicks <mort@bork.org>

---

 drivers/scsi/sata_vsc.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

e00c172b64186a6ff08e7f09086f89bedac4cc6d
diff --git a/drivers/scsi/sata_vsc.c b/drivers/scsi/sata_vsc.c
index 6d0c4f1..d97af87 100644
--- a/drivers/scsi/sata_vsc.c
+++ b/drivers/scsi/sata_vsc.c
@@ -297,7 +297,7 @@ static const struct ata_port_operations 
 	.bmdma_status		= ata_bmdma_status,
 	.qc_prep		= ata_qc_prep,
 	.qc_issue		= ata_qc_issue_prot,
-	.data_xfer		= ata_pio_data_xfer,
+	.data_xfer		= ata_mmio_data_xfer,
 	.freeze			= ata_bmdma_freeze,
 	.thaw			= ata_bmdma_thaw,
 	.error_handler		= ata_bmdma_error_handler,
-- 
1.3.2


-- 
Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE

             reply	other threads:[~2006-06-28 16:17 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2006-06-28 16:17 Martin Hicks [this message]
2006-07-06  1:44 ` [PATCH] sata_vsc: data_xfer should use mmio Jeff Garzik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20060628161747.GC16658@bork.org \
    --to=mort@bork.org \
    --cc=jgarzik@pobox.com \
    --cc=linux-ide@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).