Re: [PATCH] libata: PHY reset requires writing 0x4 to SControl

[Martin Hicks <mort@bork.org>]

Whoops.  I should have pointed out that this is untested.  Only the ahci
and sata_nv use this function, I think.  I don't have hardware for
either.

mh

On Wed, Jul 05, 2006 at 03:06:13PM -0400, Martin Hicks wrote:
> 
> Hi,
> 
> Reading the Intel VSC and AHCI it seems like writing 0x302 is incorrect.
> The only valid values are 4, 1 and 0.  Writing 4 disables the
> PHY.
> 
> Signed-off-by: Martin Hicks <mort@bork.org>
> 
> ---
> 
>  drivers/scsi/libata-core.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> 99377743755ef015100ab52fd79ee950a783141b
> diff --git a/drivers/scsi/libata-core.c b/drivers/scsi/libata-core.c
> index 6c66877..577fbcc 100644
> --- a/drivers/scsi/libata-core.c
> +++ b/drivers/scsi/libata-core.c
> @@ -2705,7 +2705,7 @@ int sata_std_hardreset(struct ata_port *
>  		if ((rc = sata_scr_read(ap, SCR_CONTROL, &scontrol)))
>  			return rc;
>  
> -		scontrol = (scontrol & 0x0f0) | 0x302;
> +		scontrol = (scontrol & 0x0f0) | 0x304;
>  
>  		if ((rc = sata_scr_write(ap, SCR_CONTROL, scontrol)))
>  			return rc;
> -- 
> 1.3.2
> 
> -
> To unsubscribe from this list: send the line "unsubscribe linux-ide" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

-- 
Martin Hicks || mort@bork.org || PGP/GnuPG: 0x4C7F2BEE