From: Brent Casavant <bcasavan@sgi.com>
To: John Keller <jpk@sgi.com>
Cc: linux-kernel@vger.kernel.org, linux-ide@vger.kernel.org
Subject: Re: [PATCH 1/1] - sgiioc4: fixup use of mmio ops
Date: Wed, 12 Jul 2006 18:11:18 -0500 (CDT) [thread overview]
Message-ID: <20060712180643.N27752@pkunk.americas.sgi.com> (raw)
In-Reply-To: <20060712175714.16943.10799.sendpatchset@attica.americas.sgi.com>
On Wed, 12 Jul 2006, John Keller wrote:
> sgiioc4.c had been recently converted to using mmio ops.
> There are still a few issues to cleanup.
An issue I noticed the other day is that we really should be turning
on CONFIG_IDEPCI_SHARE_IRQ whenever CONFIG_BLK_DEV_SGIIOC4 is selected.
The IOC4 IDE part shares a PCI interrupt with the other IOC4 devices
(serial, external interrupts), so it is effectively always sharing an
IRQ.
I just haven't created the patch yet, and will be out of the office
until next Tuesday. You might want to consider fixing this side-issue
as well as long as you're touching the IOC4 IDE code.
Brent
--
Brent Casavant All music is folk music. I ain't
bcasavan@sgi.com never heard a horse sing a song.
Silicon Graphics, Inc. -- Louis Armstrong
next prev parent reply other threads:[~2006-07-12 23:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-07-12 17:57 [PATCH 1/1] - sgiioc4: fixup use of mmio ops John Keller
2006-07-12 19:52 ` Jeremy Higdon
2006-07-12 20:36 ` Jeff Garzik
2006-07-13 13:54 ` John Keller
2006-07-13 14:45 ` Jeff Garzik
2006-07-12 23:11 ` Brent Casavant [this message]
-- strict thread matches above, loose matches on Subject: below --
2006-07-19 15:31 John Keller
2006-07-20 5:19 ` Jeremy Higdon
2006-07-21 13:16 ` Andrew Morton
2006-07-24 13:56 John Keller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060712180643.N27752@pkunk.americas.sgi.com \
--to=bcasavan@sgi.com \
--cc=jpk@sgi.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).