Re: [linux-pm] [patch, rft] amd74xx: implement suspend-to-ram

[David Brownell <david-b@pacbell.net>]

On Tuesday 25 July 2006 4:09 pm, Pavel Machek wrote:

> 
> > +	if(state.event == PM_EVENT_SUSPEND) {
> 
> "if (". Ouch 

He already got that feedback, along with the fact that PM_EVENT_SUSPEND
gets called in _all_ suspend sequences not just "standby" and STR.  That
comment just needs to be removed.  :)


> and please don't do this. Suspend-to-disk will call 
> amd74xx_resume when it needs to talk to the disk.

I don't understand the rest of this comment.  That code looks
correct (other than calling the goofy/broken pci_choose_state thing);
PM_EVENT_FREEZE and PM_EVENT_PRETHAW should not disable the device.

So what "this" are you suggesting he not do ... and why?  


> > +		pci_disable_device(dev);
> > +		pci_set_power_state(dev, pci_choose_state(dev, state));
> > +	}
> > +	return 0;
> > +}
> 
>