From: Jens Axboe <axboe@kernel.dk>
To: Pavel Machek <pavel@ucw.cz>
Cc: Lee Trager <Lee@PicturesInMotion.net>,
B.Zolnierkiewicz@elka.pw.edu.pl, linux-ide@vger.kernel.org,
linux-kernel@vger.kernel.org, akpm@osdl.org, seife@suse.de
Subject: Re: HPA Resume patch
Date: Sun, 27 Aug 2006 19:05:01 +0200 [thread overview]
Message-ID: <20060827170501.GD30609@kernel.dk> (raw)
In-Reply-To: <20060827150608.GA4534@ucw.cz>
On Sun, Aug 27 2006, Pavel Machek wrote:
> Hi!
>
> > This patch fixes a problem with computers that have HPA on their hard
> > drive and not being able to come out of resume from RAM or disk. I've
> > tested this patch on 2.6.17.x and 2.6.18-rc4 and it works great on both
> > of these. This patch also fixes the bug #6840. This is my first patch to
> > the kernel and I was told to e-mail the above people to get my patch
> > into the kernel.
>
> Congratulations for a first patch.
>
> > If I made a mistake please be gentle and correct me ;)
>
> We'll need signed-off-by: line next time.
>
> Stefan, can we get this some testing? Or anyone else with thinkpad
> with host-protected area still enabled?
It has design issues, at someone else already noticed. hpa restore needs
to be a driver private step, included in the resume state machine. The
current patch is a gross layering violation.
But thanks to Lee for taking a stab at this, I hope he'll continue and
get it polished :-)
--
Jens Axboe
next prev parent reply other threads:[~2006-08-27 17:02 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-08-27 8:42 HPA Resume patch Lee Trager
2006-08-27 10:16 ` Sergey Vlasov
2006-08-27 15:06 ` Pavel Machek
2006-08-27 17:05 ` Jens Axboe [this message]
2006-08-29 2:14 ` Lee Trager
2006-08-29 4:00 ` Randy.Dunlap
2006-08-29 9:10 ` Lee Trager
2006-08-29 9:12 ` Jens Axboe
2006-09-02 8:53 ` Lee Trager
2006-08-29 14:14 ` Valdis.Kletnieks
2006-08-27 17:09 ` Randy.Dunlap
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060827170501.GD30609@kernel.dk \
--to=axboe@kernel.dk \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=Lee@PicturesInMotion.net \
--cc=akpm@osdl.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=seife@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).