Re: What's in libata-dev.git

[Jens Axboe <axboe@kernel.dk>]

On Mon, Sep 11 2006, Linus Torvalds wrote:
> 
> 
> On Mon, 11 Sep 2006, Jens Axboe wrote:
> > 
> > So this is a confirmed, broken case? Why has no one complained for 2.4
> > and 2.6?
> 
> Oh, I didn't even notice that we do that by default already. That's a bit 
> scary - I remember people having their disks trashed.
> 
> Maybe the broken disks are old enough to not be an issue any more, or 
> maybe something else makes it effectively impossible to trigger in 
> practice?

Well, as I said, I don't think we ever saw a case that was demonstrably
due to the 256 sector issue. And I really don't think it is as obscure a
fact that people seem to think it is.

> You do need to get 32 pages of contiguous IO for it to happen, and while I 
> don't see anything else that would limit it, maybe there is something that 
> does? (Some other limiter like max_phys_segments might, but that 
> particular one defaults to much more than 32)

It should be pretty trivial to reach, the other IDE limits are basically
way beyond 128kb of contig io. People are hitting this during boot even
I bet, so...

> Of course, we do hopefully handle requests that fail a lot more 
> gracefully these days, so if the drive says it didn't do it, maybe we just 
> fix it up properly, in a way we didn't use to.. Ie we may have fixed the 
> thing that caused corruption just by fixing something else ;)

If the firmware is really buggy in that it doesn't recognise the 0 case
as being 256, you'd see immediate transfer errors. This going by
unnoticed is highly unlikely.

-- 
Jens Axboe