From: Andrew Morton <akpm@osdl.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>,
linux-kernel@vger.kernel.org,
"linux-ide@vger.kernel.org" <linux-ide@vger.kernel.org>,
alan@lxorguk.ukuu.org.uk,
"Nelson A. de Oliveira" <naoliv@gmail.com>
Subject: Re: [PATCH] libata: fix non-uniform ports handling
Date: Fri, 15 Sep 2006 15:29:32 -0700 [thread overview]
Message-ID: <20060915152932.6aafff8e.akpm@osdl.org> (raw)
In-Reply-To: <20060915180415.GB25800@htj.dyndns.org>
On Sat, 16 Sep 2006 03:04:15 +0900
Tejun Heo <htejun@gmail.com> wrote:
> @@ -5269,11 +5269,19 @@ void ata_port_init(struct ata_port *ap,
> ap->host = host;
> ap->dev = ent->dev;
> ap->port_no = port_no;
> - ap->pio_mask = ent->pio_mask;
> - ap->mwdma_mask = ent->mwdma_mask;
> - ap->udma_mask = ent->udma_mask;
> - ap->flags |= ent->port_flags;
> - ap->ops = ent->port_ops;
> + if (port_no == 1 && ent->pinfo2) {
> + ap->pio_mask = ent->pinfo2->pio_mask;
> + ap->mwdma_mask = ent->pinfo2->mwdma_mask;
> + ap->udma_mask = ent->pinfo2->udma_mask;
> + ap->flags |= ent->pinfo2->flags;
> + ap->ops = ent->pinfo2->port_ops;
> + } else {
> + ap->pio_mask = ent->pio_mask;
> + ap->mwdma_mask = ent->mwdma_mask;
> + ap->udma_mask = ent->udma_mask;
> + ap->flags |= ent->port_flags;
> + ap->ops = ent->port_ops;
> + }
Same problem: the git-libata-all which I pulled 30 seconds ago
has:
ap->flags |= ent->port_flags | ent->_port_flags[port_no];
and not
ap->flags |= ent->port_flags;
which is what your patch expects.
Oh well, hopefully Jeff will sort it out.
next prev parent reply other threads:[~2006-09-15 22:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-15 18:04 [PATCH] libata: fix non-uniform ports handling Tejun Heo
2006-09-15 18:32 ` Alan Cox
2006-09-15 22:29 ` Andrew Morton [this message]
2006-09-19 4:29 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060915152932.6aafff8e.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=naoliv@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).