From: Jens Axboe <axboe@kernel.dk>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Tejun Heo <htejun@gmail.com>, Jeff Garzik <jgarzik@pobox.com>,
linux-ide@vger.kernel.org, ric@emc.com
Subject: Re: [PATCH 2/2] libata: turn off NCQ if queue depth is adjusted to 1
Date: Sat, 30 Sep 2006 22:26:28 +0200 [thread overview]
Message-ID: <20060930202628.GF5670@kernel.dk> (raw)
In-Reply-To: <1159649460.13029.145.camel@localhost.localdomain>
On Sat, Sep 30 2006, Alan Cox wrote:
> Ar Sad, 2006-09-30 am 20:04 +0200, ysgrifennodd Jens Axboe:
> > On Sat, Sep 30 2006, Tejun Heo wrote:
> > > Turn off NCQ if queue depth is adjusted to 1.
> >
> > I had thought of that too but discarded it - it would be nicer to have
> > an independent way of turning off NCQ. Say you are debugging a weird FIS
> > issue, NCQ depth 1 is still a different beast to non-NCQ. I see Jeff
> > already applied the patches, but just thought I'd voice my opinion.
>
> I've got a blacklist for NCQ in my work tree but really we need the
> vendors to help fill it. So far it has some raptors in it but I am sure
> there are more, and I am sure there are cases we should be advising
> newer firmware or just tweaking our queue sizes etc.
Lots of the older Maxtors are pretty crappy for NCQ, so those too. Queue
size tweaks fixed them for me (as low as 4, and I can't say for sure if
it fixes all crashes).
--
Jens Axboe
next prev parent reply other threads:[~2006-09-30 20:27 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-09-30 10:44 [PATCH 1/2] libata: cosmetic changes to constants Tejun Heo
2006-09-30 10:45 ` [PATCH 2/2] libata: turn off NCQ if queue depth is adjusted to 1 Tejun Heo
2006-09-30 18:04 ` Jens Axboe
2006-09-30 20:51 ` Alan Cox
2006-09-30 20:26 ` Jens Axboe [this message]
2006-10-01 0:17 ` Ric Wheeler
2006-10-01 0:29 ` Tejun Heo
2006-10-01 0:52 ` Ric Wheeler
2006-10-01 12:56 ` Ric Wheeler
2006-12-16 17:19 ` Jeff Garzik
2006-12-18 10:04 ` Jens Axboe
2006-10-01 19:55 ` Jens Axboe
2006-10-04 13:37 ` saeed bishara
2006-10-04 13:37 ` Jens Axboe
2006-10-05 9:08 ` Jens Axboe
2006-09-30 11:39 ` [PATCH 1/2] libata: cosmetic changes to constants Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20060930202628.GF5670@kernel.dk \
--to=axboe@kernel.dk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=ric@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).