linux-ide.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@elte.hu>
To: Adrian Bunk <bunk@stusta.de>
Cc: Linus Torvalds <torvalds@osdl.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	Klaus Knopper <knopper@knopper.net>, Andi Kleen <ak@suse.de>,
	Luca Tettamanti <kronos.it@gmail.com>,
	gregkh@suse.de, linux-pci@atrey.karlin.mff.cuni.cz,
	discuss@x86-64.org, Thierry Vignaud <tvignaud@mandriva.com>,
	jgarzik@pobox.com, linux-ide@vger.kernel.org,
	"Michael S. Tsirkin" <mst@mellanox.co.il>,
	len.brown@intel.com, linux-acpi@vger.kernel.org,
	Olaf Hering <olaf@aepfle.de>, Jens Axboe <axboe@suse.de>,
	Andrew Morton <akpm@osdl.org>
Subject: [patch] x86, fix rwsem build bug on CONFIG_M386=y
Date: Thu, 5 Oct 2006 10:27:58 +0200	[thread overview]
Message-ID: <20061005082757.GA27120@elte.hu> (raw)
In-Reply-To: <20061005042816.GD16812@stusta.de>


* Adrian Bunk <bunk@stusta.de> wrote:

> This email lists some known regressions in 2.6.19-rc1 compared to 
> 2.6.18.

thanks Adrian - this list is extremely useful in my opinion! Please keep 
up the good work.

> Subject    : CONFIG_M386=y rwsem compile error
> References : http://lkml.org/lkml/2006/10/3/240
> Submitter  : Klaus Knopper <knopper@knopper.net>
> Guilty     : Andi Kleen <ak@suse.de>
>              commit add659bf8aa92f8b3f01a8c0220557c959507fb1
> Status     : unknown

find the fix below.

-------------------->
Subject: [patch] x86, fix rwsem build bug on CONFIG_M386=y
From: Ingo Molnar <mingo@elte.hu>

CONFIG_M386 turns on spinlock-based generic rwsems - which surprises the 
semaphore.S rwsem stubs. Tested both with and without CONFIG_M386.

Reported-by: Klaus Knopper <knopper@knopper.net>
Triaged-by: Adrian Bunk <bunk@stusta.de>

Signed-off-by: Ingo Molnar <mingo@elte.hu>
---
 arch/i386/lib/semaphore.S |    3 +++
 1 file changed, 3 insertions(+)

Index: linux/arch/i386/lib/semaphore.S
===================================================================
--- linux.orig/arch/i386/lib/semaphore.S
+++ linux/arch/i386/lib/semaphore.S
@@ -152,6 +152,8 @@ ENTRY(__read_lock_failed)
 
 #endif
 
+#ifdef CONFIG_RWSEM_XCHGADD_ALGORITHM
+
 /* Fix up special calling conventions */
 ENTRY(call_rwsem_down_read_failed)
 	CFI_STARTPROC
@@ -214,3 +216,4 @@ ENTRY(call_rwsem_downgrade_wake)
 	CFI_ENDPROC
 	END(call_rwsem_downgrade_wake)
 
+#endif

  parent reply	other threads:[~2006-10-05  8:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <Pine.LNX.4.64.0610042017340.3952@g5.osdl.org>
2006-10-05  4:28 ` 2.6.19-rc1: known regressions Adrian Bunk
2006-10-05  7:16   ` Nigel Cunningham
2006-10-05  8:27   ` Ingo Molnar [this message]
2006-10-05  9:41     ` [discuss] [patch] x86, fix rwsem build bug on CONFIG_M386=y Andi Kleen
2006-10-07 21:46 ` 2.6.19-rc1: known regressions (v2) Adrian Bunk
2006-10-08  8:56   ` matthieu castet
2006-10-10  5:10 ` 2.6.19-rc1: known regressions (v3) Adrian Bunk
2006-10-10 22:58   ` Paul Mackerras

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20061005082757.GA27120@elte.hu \
    --to=mingo@elte.hu \
    --cc=ak@suse.de \
    --cc=akpm@osdl.org \
    --cc=axboe@suse.de \
    --cc=bunk@stusta.de \
    --cc=discuss@x86-64.org \
    --cc=gregkh@suse.de \
    --cc=jgarzik@pobox.com \
    --cc=knopper@knopper.net \
    --cc=kronos.it@gmail.com \
    --cc=len.brown@intel.com \
    --cc=linux-acpi@vger.kernel.org \
    --cc=linux-ide@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-pci@atrey.karlin.mff.cuni.cz \
    --cc=mst@mellanox.co.il \
    --cc=olaf@aepfle.de \
    --cc=torvalds@osdl.org \
    --cc=tvignaud@mandriva.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).