From: Ingo Molnar <mingo@elte.hu>
To: Arjan van de Ven <arjan@infradead.org>
Cc: Jens Axboe <jens.axboe@oracle.com>, Mark Lord <liml@rtr.ca>,
IDE/ATA development list <linux-ide@vger.kernel.org>,
Linux Kernel <linux-kernel@vger.kernel.org>
Subject: Re: 2.6.19-rc3-git7: scsi_device_unbusy: inconsistent lock state
Date: Mon, 30 Oct 2006 18:57:44 +0100 [thread overview]
Message-ID: <20061030175744.GA384@elte.hu> (raw)
In-Reply-To: <1162230993.2948.60.camel@laptopd505.fenrus.org>
* Arjan van de Ven <arjan@infradead.org> wrote:
> > struct rb_node *parent;
> > struct cfq_io_context *__cic;
> > + unsigned long flags;
> > void *k;
> >
> > cic->ioc = ioc;
> > @@ -1384,9 +1385,9 @@ restart:
> > rb_link_node(&cic->rb_node, parent, p);
> > rb_insert_color(&cic->rb_node, &ioc->cic_root);
> >
> > - spin_lock_irq(cfqd->queue->queue_lock);
> > + spin_lock_irqsave(cfqd->queue->queue_lock, flags);
> > list_add(&cic->queue_list, &cfqd->cic_list);
> > - spin_unlock_irq(cfqd->queue->queue_lock);
> > + spin_unlock_irqrestore(cfqd->queue->queue_lock, flags);
> > }
>
> this looks entirely reasonable and correct
>
> Acked-By: Arjan van de Ven <arjan@linux.intel.com>
yep.
Acked-by: Ingo Molnar <mingo@elte.hu>
Ingo
prev parent reply other threads:[~2006-10-30 17:57 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-10-30 14:33 2.6.19-rc3-git7: scsi_device_unbusy: inconsistent lock state Mark Lord
2006-10-30 14:43 ` Jens Axboe
2006-10-30 14:57 ` Arjan van de Ven
2006-10-30 15:44 ` Jens Axboe
2006-10-30 16:16 ` Arjan van de Ven
2006-10-30 16:26 ` Jens Axboe
2006-10-30 16:31 ` Arjan van de Ven
2006-10-30 17:52 ` Jens Axboe
2006-10-30 17:54 ` Ingo Molnar
2006-10-30 18:03 ` Jens Axboe
2006-10-30 17:54 ` Mark Lord
2006-10-30 18:11 ` Mark Lord
2006-10-30 18:16 ` Jens Axboe
2006-10-30 18:30 ` Mark Lord
2006-10-30 18:35 ` Mark Lord
2006-10-30 18:45 ` Arjan van de Ven
2006-10-30 18:56 ` Jens Axboe
2006-10-30 18:52 ` Jens Axboe
2006-10-30 18:59 ` Mark Lord
2006-10-30 19:04 ` Jens Axboe
2006-10-30 18:20 ` Mark Lord
2006-10-30 17:56 ` Arjan van de Ven
2006-10-30 17:57 ` Ingo Molnar [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061030175744.GA384@elte.hu \
--to=mingo@elte.hu \
--cc=arjan@infradead.org \
--cc=jens.axboe@oracle.com \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).