* Re: [PATCH] pata_artop: fix "& (1 >>" typo
2006-11-10 19:52 [PATCH] pata_artop: fix "& (1 >>" typo Alexey Dobriyan
@ 2006-11-10 16:25 ` Alan Cox
2006-11-14 14:52 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Alan Cox @ 2006-11-10 16:25 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Andrew Morton, Alan Cox, linux-ide, devel
On Fri, Nov 10, 2006 at 10:52:46PM +0300, Alexey Dobriyan wrote:
> Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
Acked-by: Alan Cox <alan@redhat.com>
> ---
>
> drivers/ata/pata_artop.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> --- a/drivers/ata/pata_artop.c
> +++ b/drivers/ata/pata_artop.c
> @@ -92,7 +92,7 @@ static int artop6260_pre_reset(struct at
> return -ENOENT;
>
> pci_read_config_byte(pdev, 0x49, &tmp);
> - if (tmp & (1 >> ap->port_no))
> + if (tmp & (1 << ap->port_no))
> ap->cbl = ATA_CBL_PATA40;
> else
> ap->cbl = ATA_CBL_PATA80;
--
"People who choose variable names like htlbpagek SHOULD be sent to
produce a street map of R'Lyeh. On site."
-- Al Viro
^ permalink raw reply [flat|nested] 3+ messages in thread
* [PATCH] pata_artop: fix "& (1 >>" typo
@ 2006-11-10 19:52 Alexey Dobriyan
2006-11-10 16:25 ` Alan Cox
2006-11-14 14:52 ` Jeff Garzik
0 siblings, 2 replies; 3+ messages in thread
From: Alexey Dobriyan @ 2006-11-10 19:52 UTC (permalink / raw)
To: Andrew Morton; +Cc: Alan Cox, linux-ide, devel
Signed-off-by: Alexey Dobriyan <adobriyan@openvz.org>
---
drivers/ata/pata_artop.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
--- a/drivers/ata/pata_artop.c
+++ b/drivers/ata/pata_artop.c
@@ -92,7 +92,7 @@ static int artop6260_pre_reset(struct at
return -ENOENT;
pci_read_config_byte(pdev, 0x49, &tmp);
- if (tmp & (1 >> ap->port_no))
+ if (tmp & (1 << ap->port_no))
ap->cbl = ATA_CBL_PATA40;
else
ap->cbl = ATA_CBL_PATA80;
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: [PATCH] pata_artop: fix "& (1 >>" typo
2006-11-10 19:52 [PATCH] pata_artop: fix "& (1 >>" typo Alexey Dobriyan
2006-11-10 16:25 ` Alan Cox
@ 2006-11-14 14:52 ` Jeff Garzik
1 sibling, 0 replies; 3+ messages in thread
From: Jeff Garzik @ 2006-11-14 14:52 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: Andrew Morton, Alan Cox, linux-ide, devel
applied
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-11-14 14:52 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-10 19:52 [PATCH] pata_artop: fix "& (1 >>" typo Alexey Dobriyan
2006-11-10 16:25 ` Alan Cox
2006-11-14 14:52 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).