From: Nicolas Kaiser <nikai@nikai.net>
To: Alexey Dobriyan <adobriyan@gmail.com>
Cc: linux-ide@vger.kernel.org, trivial@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH][TRIVIAL] drivers/ide: stray bracket
Date: Sat, 11 Nov 2006 17:21:12 +0100 [thread overview]
Message-ID: <20061111172112.7e1aba49@lucky.kitzblitz> (raw)
In-Reply-To: <20061111131612.GA4974@martell.zuzino.mipt.ru>
* Alexey Dobriyan <adobriyan@gmail.com>:
> On Sat, Nov 11, 2006 at 01:47:56AM +0100, Nicolas Kaiser wrote:
> > Stray bracket in debug code.
> Just remove whole printk. It was broken for a looong time.
If you prefer it that way, here we go:
Remove debug code that was broken for long time.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/ide/legacy/hd.c | 5 -----
1 file changed, 5 deletions(-)
diff -uprN a/drivers/ide/legacy/hd.c b/drivers/ide/legacy/hd.c
--- a/drivers/ide/legacy/hd.c 2006-09-20 05:42:06.000000000 +0200
+++ b/drivers/ide/legacy/hd.c 2006-11-11 17:11:28.000000000 +0100
@@ -456,11 +456,6 @@ ok_to_read:
req->errors = 0;
i = --req->nr_sectors;
--req->current_nr_sectors;
-#ifdef DEBUG
- printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
- req->rq_disk->disk_name, req->sector, req->nr_sectors,
- req->buffer+512));
-#endif
if (req->current_nr_sectors <= 0)
end_request(req, 1);
if (i > 0) {
prev parent reply other threads:[~2006-11-11 16:23 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-11 0:47 [PATCH][TRIVIAL] drivers/ide: stray bracket Nicolas Kaiser
2006-11-11 13:16 ` Alexey Dobriyan
2006-11-11 16:21 ` Nicolas Kaiser [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061111172112.7e1aba49@lucky.kitzblitz \
--to=nikai@nikai.net \
--cc=adobriyan@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=trivial@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).