* [PATCH][TRIVIAL] drivers/ide: stray bracket
@ 2006-11-11 0:47 Nicolas Kaiser
2006-11-11 13:16 ` Alexey Dobriyan
0 siblings, 1 reply; 3+ messages in thread
From: Nicolas Kaiser @ 2006-11-11 0:47 UTC (permalink / raw)
To: linux-ide; +Cc: trivial, linux-kernel
Stray bracket in debug code.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/ide/legacy/hd.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -uprN a/drivers/ide/legacy/hd.c b/drivers/ide/legacy/hd.c
--- a/drivers/ide/legacy/hd.c 2006-09-20 05:42:06.000000000 +0200
+++ b/drivers/ide/legacy/hd.c 2006-11-10 21:52:20.000000000 +0100
@@ -459,7 +459,7 @@ ok_to_read:
#ifdef DEBUG
printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
req->rq_disk->disk_name, req->sector, req->nr_sectors,
- req->buffer+512));
+ req->buffer+512);
#endif
if (req->current_nr_sectors <= 0)
end_request(req, 1);
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][TRIVIAL] drivers/ide: stray bracket
2006-11-11 0:47 [PATCH][TRIVIAL] drivers/ide: stray bracket Nicolas Kaiser
@ 2006-11-11 13:16 ` Alexey Dobriyan
2006-11-11 16:21 ` Nicolas Kaiser
0 siblings, 1 reply; 3+ messages in thread
From: Alexey Dobriyan @ 2006-11-11 13:16 UTC (permalink / raw)
To: Nicolas Kaiser; +Cc: linux-ide, trivial, linux-kernel
On Sat, Nov 11, 2006 at 01:47:56AM +0100, Nicolas Kaiser wrote:
> Stray bracket in debug code.
> --- a/drivers/ide/legacy/hd.c 2006-09-20 05:42:06.000000000 +0200
> +++ b/drivers/ide/legacy/hd.c 2006-11-10 21:52:20.000000000 +0100
> @@ -459,7 +459,7 @@ ok_to_read:
> #ifdef DEBUG
> printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
> req->rq_disk->disk_name, req->sector, req->nr_sectors,
> - req->buffer+512));
> + req->buffer+512);
> #endif
Just remove whole printk. It was broken for a looong time.
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH][TRIVIAL] drivers/ide: stray bracket
2006-11-11 13:16 ` Alexey Dobriyan
@ 2006-11-11 16:21 ` Nicolas Kaiser
0 siblings, 0 replies; 3+ messages in thread
From: Nicolas Kaiser @ 2006-11-11 16:21 UTC (permalink / raw)
To: Alexey Dobriyan; +Cc: linux-ide, trivial, linux-kernel
* Alexey Dobriyan <adobriyan@gmail.com>:
> On Sat, Nov 11, 2006 at 01:47:56AM +0100, Nicolas Kaiser wrote:
> > Stray bracket in debug code.
> Just remove whole printk. It was broken for a looong time.
If you prefer it that way, here we go:
Remove debug code that was broken for long time.
Signed-off-by: Nicolas Kaiser <nikai@nikai.net>
---
drivers/ide/legacy/hd.c | 5 -----
1 file changed, 5 deletions(-)
diff -uprN a/drivers/ide/legacy/hd.c b/drivers/ide/legacy/hd.c
--- a/drivers/ide/legacy/hd.c 2006-09-20 05:42:06.000000000 +0200
+++ b/drivers/ide/legacy/hd.c 2006-11-11 17:11:28.000000000 +0100
@@ -456,11 +456,6 @@ ok_to_read:
req->errors = 0;
i = --req->nr_sectors;
--req->current_nr_sectors;
-#ifdef DEBUG
- printk("%s: read: sector %ld, remaining = %ld, buffer=%p\n",
- req->rq_disk->disk_name, req->sector, req->nr_sectors,
- req->buffer+512));
-#endif
if (req->current_nr_sectors <= 0)
end_request(req, 1);
if (i > 0) {
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2006-11-11 16:23 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-11 0:47 [PATCH][TRIVIAL] drivers/ide: stray bracket Nicolas Kaiser
2006-11-11 13:16 ` Alexey Dobriyan
2006-11-11 16:21 ` Nicolas Kaiser
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).