From: Andrew Morton <akpm@osdl.org>
To: Tejun Heo <htejun@gmail.com>
Cc: Jens Axboe <axboe@suse.de>,
dougg@torque.net, mfluhr@nero.com, alan@lxorguk.ukuu.org.uk,
jgarzik@pobox.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] clear garbage after CDBs on SG_IO
Date: Thu, 16 Nov 2006 00:49:03 -0800 [thread overview]
Message-ID: <20061116004903.ed9b81ac.akpm@osdl.org> (raw)
In-Reply-To: <20061116005227.GD27684@htj.dyndns.org>
On Thu, 16 Nov 2006 09:52:27 +0900
Tejun Heo <htejun@gmail.com> wrote:
> ATAPI devices transfer fixed number of bytes for CDBs (12 or 16).
> Some ATAPI devices choke when shorter CDB is used and the left bytes
> contain garbage. Block SG_IO cleared left bytes but SCSI SG_IO
> didn't. This patch makes SCSI SG_IO clear it and simplify CDB
> clearing in block SG_IO.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
> Cc: Mathieu Fluhr <mfluhr@nero.com>
>
> diff --git a/block/scsi_ioctl.c b/block/scsi_ioctl.c
> index 2dc3264..cac7f18 100644
> --- a/block/scsi_ioctl.c
> +++ b/block/scsi_ioctl.c
> @@ -286,9 +286,8 @@ static int sg_io(struct file *file, requ
> * fill in request structure
> */
> rq->cmd_len = hdr->cmd_len;
> + memset(req->cmd, 0, BLK_MAX_CDB); /* ATAPI hates garbage after CDB */
s/req/rq/ makes the compiler happier there.
next prev parent reply other threads:[~2006-11-16 8:50 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-16 0:52 [PATCH] clear garbage after CDBs on SG_IO Tejun Heo
2006-11-16 1:52 ` Jeff Garzik
2006-11-16 8:49 ` Andrew Morton [this message]
2006-11-16 11:47 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061116004903.ed9b81ac.akpm@osdl.org \
--to=akpm@osdl.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=axboe@suse.de \
--cc=dougg@torque.net \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=mfluhr@nero.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).