From: Russell King <rmk+pcmcia@arm.linux.org.uk>
To: linux-pcmcia@lists.infradead.org, linux-ide@vger.kernel.org,
alan@lxorguk.ukuu.org.uk
Subject: Re: [PATCH 1/8] pcmcia: Add an id to ide-cs.c
Date: Mon, 20 Nov 2006 09:53:49 +0000 [thread overview]
Message-ID: <20061120095349.GA15410@flint.arm.linux.org.uk> (raw)
In-Reply-To: <20061119163851.GB2924@dominikbrodowski.de>
On Sun, Nov 19, 2006 at 11:38:51AM -0500, Dominik Brodowski wrote:
>
> From: Matt Reimer <mattjreimer@gmail.com>
> Date: Thu, 26 Oct 2006 15:56:00 -0700
> Subject: [PATCH] pcmcia: Add an id to ide-cs.c
>
> Add an ID entry for:
>
> product info: "TRANSCEND", "TS1GCF80", "", ""
> manfid: 0x000a, 0x0000
> function: 4 (fixed disk)
Erm, silly question: isn't this supposed to be matched by the following:
static struct pcmcia_device_id ide_ids[] = {
PCMCIA_DEVICE_FUNC_ID(4),
or are we going to be ignoring the function ID and only matching using
the manfid and product info strings?
--
Russell King
Linux kernel 2.6 ARM Linux - http://www.arm.linux.org.uk/
maintainer of: 2.6 Serial core
next prev parent reply other threads:[~2006-11-20 9:53 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061119163427.GA2924@dominikbrodowski.de>
2006-11-19 16:38 ` [PATCH 1/8] pcmcia: Add an id to ide-cs.c Dominik Brodowski
2006-11-20 9:53 ` Russell King [this message]
2006-11-20 17:43 ` Dominik Brodowski
2006-11-20 21:07 ` Russell King
2006-11-19 16:39 ` [PATCH 2/8] pcmcia: yet another IDE ID Dominik Brodowski
2006-11-19 17:05 ` Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061120095349.GA15410@flint.arm.linux.org.uk \
--to=rmk+pcmcia@arm.linux.org.uk \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=linux-pcmcia@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).