* [PATCH 1/1] sgiioc4: Disable module unload
@ 2006-11-21 3:15 Jeremy Higdon
2006-11-22 1:28 ` Andrew Morton
0 siblings, 1 reply; 5+ messages in thread
From: Jeremy Higdon @ 2006-11-21 3:15 UTC (permalink / raw)
To: linux-ide, akpm
This patch removes a module_exit function that it sgiioc4 should not have had.
Signed-off-by: Jeremy Higdon <jeremy@sgi.com>
--- linux-2.6.19-rc6/drivers/ide/pci/sgiioc4.c 2006-11-15 20:03:40.000000000 -0800
+++ linux-2.6.19-rc6-mod/drivers/ide/pci/sgiioc4.c 2006-11-20 18:45:08.506724280 -0800
@@ -768,14 +768,7 @@
return ioc4_register_submodule(&ioc4_ide_submodule);
}
-static void __devexit
-ioc4_ide_exit(void)
-{
- ioc4_unregister_submodule(&ioc4_ide_submodule);
-}
-
late_initcall(ioc4_ide_init); /* Call only after IDE init is done */
-module_exit(ioc4_ide_exit);
MODULE_AUTHOR("Aniket Malatpure/Jeremy Higdon");
MODULE_DESCRIPTION("IDE PCI driver module for SGI IOC4 Base-IO Card");
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] sgiioc4: Disable module unload
2006-11-21 3:15 [PATCH 1/1] sgiioc4: Disable module unload Jeremy Higdon
@ 2006-11-22 1:28 ` Andrew Morton
2006-11-22 1:59 ` Jeremy Higdon
0 siblings, 1 reply; 5+ messages in thread
From: Andrew Morton @ 2006-11-22 1:28 UTC (permalink / raw)
To: Jeremy Higdon; +Cc: linux-ide
On Mon, 20 Nov 2006 19:15:52 -0800
Jeremy Higdon <jeremy@sgi.com> wrote:
> This patch removes a module_exit function that it sgiioc4 should not have had.
>
> Signed-off-by: Jeremy Higdon <jeremy@sgi.com>
>
>
> --- linux-2.6.19-rc6/drivers/ide/pci/sgiioc4.c 2006-11-15 20:03:40.000000000 -0800
> +++ linux-2.6.19-rc6-mod/drivers/ide/pci/sgiioc4.c 2006-11-20 18:45:08.506724280 -0800
> @@ -768,14 +768,7 @@
> return ioc4_register_submodule(&ioc4_ide_submodule);
> }
>
> -static void __devexit
> -ioc4_ide_exit(void)
> -{
> - ioc4_unregister_submodule(&ioc4_ide_submodule);
> -}
> -
> late_initcall(ioc4_ide_init); /* Call only after IDE init is done */
> -module_exit(ioc4_ide_exit);
>
> MODULE_AUTHOR("Aniket Malatpure/Jeremy Higdon");
> MODULE_DESCRIPTION("IDE PCI driver module for SGI IOC4 Base-IO Card");
Why? We'd prefer that the module be unloadable, wouldn't we?
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] sgiioc4: Disable module unload
2006-11-22 1:28 ` Andrew Morton
@ 2006-11-22 1:59 ` Jeremy Higdon
2006-11-22 2:13 ` Andrew Morton
2006-11-22 20:29 ` Bartlomiej Zolnierkiewicz
0 siblings, 2 replies; 5+ messages in thread
From: Jeremy Higdon @ 2006-11-22 1:59 UTC (permalink / raw)
To: Andrew Morton; +Cc: linux-ide
On Tue, Nov 21, 2006 at 05:28:16PM -0800, Andrew Morton wrote:
> On Mon, 20 Nov 2006 19:15:52 -0800
> Jeremy Higdon <jeremy@sgi.com> wrote:
>
> > This patch removes a module_exit function that it sgiioc4 should not have had.
> >
> > Signed-off-by: Jeremy Higdon <jeremy@sgi.com>
> >
> >
> > --- linux-2.6.19-rc6/drivers/ide/pci/sgiioc4.c 2006-11-15 20:03:40.000000000 -0800
> > +++ linux-2.6.19-rc6-mod/drivers/ide/pci/sgiioc4.c 2006-11-20 18:45:08.506724280 -0800
> > @@ -768,14 +768,7 @@
> > return ioc4_register_submodule(&ioc4_ide_submodule);
> > }
> >
> > -static void __devexit
> > -ioc4_ide_exit(void)
> > -{
> > - ioc4_unregister_submodule(&ioc4_ide_submodule);
> > -}
> > -
> > late_initcall(ioc4_ide_init); /* Call only after IDE init is done */
> > -module_exit(ioc4_ide_exit);
> >
> > MODULE_AUTHOR("Aniket Malatpure/Jeremy Higdon");
> > MODULE_DESCRIPTION("IDE PCI driver module for SGI IOC4 Base-IO Card");
>
> Why? We'd prefer that the module be unloadable, wouldn't we?
It seems that the IDE layer doesn't support that. sgiioc4 was the only
driver in drivers/ide/pci that had an exit function. After an unload,
the devices would stay around and the next attempt to reference would
crash...
Thanks,
jeremy
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] sgiioc4: Disable module unload
2006-11-22 1:59 ` Jeremy Higdon
@ 2006-11-22 2:13 ` Andrew Morton
2006-11-22 20:29 ` Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 5+ messages in thread
From: Andrew Morton @ 2006-11-22 2:13 UTC (permalink / raw)
To: Jeremy Higdon; +Cc: linux-ide
On Tue, 21 Nov 2006 17:59:52 -0800
Jeremy Higdon <jeremy@sgi.com> wrote:
> On Tue, Nov 21, 2006 at 05:28:16PM -0800, Andrew Morton wrote:
> > On Mon, 20 Nov 2006 19:15:52 -0800
> > Jeremy Higdon <jeremy@sgi.com> wrote:
> >
> > > This patch removes a module_exit function that it sgiioc4 should not have had.
> > >
> > > Signed-off-by: Jeremy Higdon <jeremy@sgi.com>
> > >
> > >
> > > --- linux-2.6.19-rc6/drivers/ide/pci/sgiioc4.c 2006-11-15 20:03:40.000000000 -0800
> > > +++ linux-2.6.19-rc6-mod/drivers/ide/pci/sgiioc4.c 2006-11-20 18:45:08.506724280 -0800
> > > @@ -768,14 +768,7 @@
> > > return ioc4_register_submodule(&ioc4_ide_submodule);
> > > }
> > >
> > > -static void __devexit
> > > -ioc4_ide_exit(void)
> > > -{
> > > - ioc4_unregister_submodule(&ioc4_ide_submodule);
> > > -}
> > > -
> > > late_initcall(ioc4_ide_init); /* Call only after IDE init is done */
> > > -module_exit(ioc4_ide_exit);
> > >
> > > MODULE_AUTHOR("Aniket Malatpure/Jeremy Higdon");
> > > MODULE_DESCRIPTION("IDE PCI driver module for SGI IOC4 Base-IO Card");
> >
> > Why? We'd prefer that the module be unloadable, wouldn't we?
>
> It seems that the IDE layer doesn't support that. sgiioc4 was the only
> driver in drivers/ide/pci that had an exit function. After an unload,
> the devices would stay around and the next attempt to reference would
> crash...
oh, OK, thanks. I updated the changelog.
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [PATCH 1/1] sgiioc4: Disable module unload
2006-11-22 1:59 ` Jeremy Higdon
2006-11-22 2:13 ` Andrew Morton
@ 2006-11-22 20:29 ` Bartlomiej Zolnierkiewicz
1 sibling, 0 replies; 5+ messages in thread
From: Bartlomiej Zolnierkiewicz @ 2006-11-22 20:29 UTC (permalink / raw)
To: Jeremy Higdon; +Cc: Andrew Morton, linux-ide
On 11/22/06, Jeremy Higdon <jeremy@sgi.com> wrote:
> On Tue, Nov 21, 2006 at 05:28:16PM -0800, Andrew Morton wrote:
> > On Mon, 20 Nov 2006 19:15:52 -0800
> > Jeremy Higdon <jeremy@sgi.com> wrote:
> >
> > > This patch removes a module_exit function that it sgiioc4 should not have had.
> > >
> > > Signed-off-by: Jeremy Higdon <jeremy@sgi.com>
> > >
> > >
> > > --- linux-2.6.19-rc6/drivers/ide/pci/sgiioc4.c 2006-11-15 20:03:40.000000000 -0800
> > > +++ linux-2.6.19-rc6-mod/drivers/ide/pci/sgiioc4.c 2006-11-20 18:45:08.506724280 -0800
> > > @@ -768,14 +768,7 @@
> > > return ioc4_register_submodule(&ioc4_ide_submodule);
> > > }
> > >
> > > -static void __devexit
> > > -ioc4_ide_exit(void)
> > > -{
> > > - ioc4_unregister_submodule(&ioc4_ide_submodule);
> > > -}
> > > -
> > > late_initcall(ioc4_ide_init); /* Call only after IDE init is done */
> > > -module_exit(ioc4_ide_exit);
> > >
> > > MODULE_AUTHOR("Aniket Malatpure/Jeremy Higdon");
> > > MODULE_DESCRIPTION("IDE PCI driver module for SGI IOC4 Base-IO Card");
> >
> > Why? We'd prefer that the module be unloadable, wouldn't we?
not supported in the current IDE layer model
(lack of dynamic allocation for ide_hwifs[] and some needed locking)
> It seems that the IDE layer doesn't support that. sgiioc4 was the only
> driver in drivers/ide/pci that had an exit function. After an unload,
> the devices would stay around and the next attempt to reference would
> crash...
ack
Andrew, please apply.
Bart
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2006-11-22 20:29 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2006-11-21 3:15 [PATCH 1/1] sgiioc4: Disable module unload Jeremy Higdon
2006-11-22 1:28 ` Andrew Morton
2006-11-22 1:59 ` Jeremy Higdon
2006-11-22 2:13 ` Andrew Morton
2006-11-22 20:29 ` Bartlomiej Zolnierkiewicz
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).