From: Alan <alan@lxorguk.ukuu.org.uk>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: akpm@osdl.org, bzolnier@gmail.com, linux-ide@vger.kernel.org
Subject: Re: [PATCH] (2.6.19-rc6-mm2) pdc202xx_new cleanup
Date: Fri, 1 Dec 2006 00:13:21 +0000 [thread overview]
Message-ID: <20061201001321.1b946f0e@localhost.localdomain> (raw)
In-Reply-To: <200611302151.33319.sshtylyov@ru.mvista.com>
I believe this is completely the wrong thing to do. Adding a ton of
changes to the existing (and stable) life expired drivers/ide driver
rather than keeping new and risky stuff in the new libata code is bad.
The existing code *works*, its been rock solid since the reset drain fix
and it is the code everyone who is conservative relies on not to eat
their data. We have somewhere to do new and cool stuff its libata.
I don't see the point in risking destabilising a good solid driver. I can
just about see justification for !X86 implementation of the PLL handling
but that is about it.
Alan
next prev parent reply other threads:[~2006-12-01 0:06 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2006-11-30 18:51 [PATCH] (2.6.19-rc6-mm2) pdc202xx_new cleanup Sergei Shtylyov
2006-12-01 0:13 ` Alan [this message]
2006-12-01 12:36 ` Sergei Shtylyov
2006-12-01 13:05 ` Sergei Shtylyov
2006-12-02 15:40 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061201001321.1b946f0e@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=akpm@osdl.org \
--cc=bzolnier@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox