From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Subject: Re: [PATCH] mark PCI resource with start 0 as unassigned Date: Mon, 4 Dec 2006 13:21:24 +0000 Message-ID: <20061204132124.4f7c50a9@localhost.localdomain> References: <20061130165202.GA23205@aepfle.de> <20061204123854.GA28159@aepfle.de> <4574197A.2020204@ru.mvista.com> <4FC2EBCF-C927-435A-9BE3-E4403AFC042D@kernel.crashing.org> <45741DDE.4080509@ru.mvista.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <45741DDE.4080509@ru.mvista.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org Errors-To: linuxppc-dev-bounces+glppd-linuxppc64-dev=m.gmane.org@ozlabs.org To: Sergei Shtylyov Cc: linux-ide@vger.kernel.org, Olaf Hering , linuxppc-dev@ozlabs.org List-Id: linux-ide@vger.kernel.org On Mon, 04 Dec 2006 16:08:46 +0300 Sergei Shtylyov wrote: > >> W82C105_IDE: inconsistent baseregs (BIOS) for port 0, skipping > > So that needs fixing too, then. Both PCI core and IDE interpret a zero length resource as unassigned. That is probably better than clearing the flags in retrospect. > I'd agree here, that check in the IDE code seems like being too x86 > specific. I'm having issues with it as well on MPC85xx/U-Boot... setup-pci is for SFF8038i devices. It therefore knows that for assigned resources they must be I/O. It also assumes that zero is not a valid I/O port just like zero is not a valid IRQ. Stick a real IDE resource at zero and drivers/ide can't cope. Alan