From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tejun Heo Subject: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops Date: Mon, 11 Dec 2006 22:26:25 +0900 Message-ID: <20061211132625.GA18947@htj.dyndns.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Received: from nz-out-0506.google.com ([64.233.162.230]:8442 "EHLO nz-out-0102.google.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1762904AbWLKN0i (ORCPT ); Mon, 11 Dec 2006 08:26:38 -0500 Received: by nz-out-0102.google.com with SMTP id s1so783658nze for ; Mon, 11 Dec 2006 05:26:37 -0800 (PST) Content-Disposition: inline In-Reply-To: Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Jeff Garzik , linux-ide@vger.kernel.org, Catalin Marinas Cc: Linux Kernel Mailing List piix_init_one() allocates host private data which should be freed by piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() while merging, leaking 4 bytes on driver detach. Fix it. This was spotted using Kmemleak by Catalin Marinas. Signed-off-by: Tejun Heo Cc: Catalin Marinas --- diff --git a/drivers/ata/ata_piix.c b/drivers/ata/ata_piix.c index c7de0bb..dfe17e1 100644 --- a/drivers/ata/ata_piix.c +++ b/drivers/ata/ata_piix.c @@ -330,7 +330,7 @@ static const struct ata_port_operations ich_pata_ops = { .port_start = ata_port_start, .port_stop = ata_port_stop, - .host_stop = ata_host_stop, + .host_stop = piix_host_stop, }; static const struct ata_port_operations piix_sata_ops = {