From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Subject: Re: [PATCH] ata_piix: use piix_host_stop() in ich_pata_ops Date: Mon, 11 Dec 2006 14:19:56 +0000 Message-ID: <20061211141956.5d161c9f@localhost.localdomain> References: <20061211132625.GA18947@htj.dyndns.org> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:52024 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1762918AbWLKONL (ORCPT ); Mon, 11 Dec 2006 09:13:11 -0500 In-Reply-To: <20061211132625.GA18947@htj.dyndns.org> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo Cc: Jeff Garzik , linux-ide@vger.kernel.org, Catalin Marinas , Linux Kernel Mailing List On Mon, 11 Dec 2006 22:26:25 +0900 Tejun Heo wrote: > piix_init_one() allocates host private data which should be freed by > piix_host_stop(). ich_pata_ops wasn't converted to piix_host_stop() > while merging, leaking 4 bytes on driver detach. Fix it. > > This was spotted using Kmemleak by Catalin Marinas. > > Signed-off-by: Tejun Heo > Cc: Catalin Marinas Acked-by: Alan Cox