From: Adrian Bunk <bunk@stusta.de>
To: Andrew Morton <akpm@osdl.org>, Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-kernel@vger.kernel.org, B.Zolnierkiewicz@elka.pw.edu.pl,
linux-ide@vger.kernel.org
Subject: [-mm patch] drivers/ide/pci/tc86c001.c: make a function static
Date: Sat, 16 Dec 2006 14:56:50 +0100 [thread overview]
Message-ID: <20061216135650.GA3388@stusta.de> (raw)
In-Reply-To: <20061214225913.3338f677.akpm@osdl.org>
On Thu, Dec 14, 2006 at 10:59:13PM -0800, Andrew Morton wrote:
>...
> Changes since 2.6.19-mm1:
>...
> +toshiba-tc86c001-ide-driver-take-2.patch
>...
> Misc.
>...
This patch makes the needlessly global init_hwif_tc86c001() static.
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
BTW:
I'm not sure whether it'd be a good idea to include such a driver for
the legacy IDE subsystem without a libata based driver for the same
hardware.
--- linux-2.6.20-rc1-mm1/drivers/ide/pci/tc86c001.c.old 2006-12-15 21:58:44.000000000 +0100
+++ linux-2.6.20-rc1-mm1/drivers/ide/pci/tc86c001.c 2006-12-15 21:58:54.000000000 +0100
@@ -204,7 +204,7 @@
return 0;
}
-void __devinit init_hwif_tc86c001(ide_hwif_t *hwif)
+static void __devinit init_hwif_tc86c001(ide_hwif_t *hwif)
{
unsigned long sc_base = pci_resource_start(hwif->pci_dev, 5);
u16 scr1 = hwif->INW(sc_base + 0x00);;
next prev parent reply other threads:[~2006-12-16 13:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <20061214225913.3338f677.akpm@osdl.org>
2006-12-15 14:46 ` OOPS: deref 0x14 at pdc_port_start+0x82 [Was: 2.6.20-rc1-mm1] Jiri Slaby
2006-12-15 19:24 ` Andrew Morton
2006-12-15 22:49 ` Jiri Slaby
2006-12-16 13:56 ` Adrian Bunk [this message]
2006-12-16 14:18 ` [-mm patch] drivers/ide/pci/tc86c001.c: make a function static Alan
2006-12-17 18:08 ` Sergei Shtylyov
2006-12-17 20:52 ` Sergei Shtylyov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20061216135650.GA3388@stusta.de \
--to=bunk@stusta.de \
--cc=B.Zolnierkiewicz@elka.pw.edu.pl \
--cc=akpm@osdl.org \
--cc=linux-ide@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).