From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mark Lord Subject: [PATCH 2.6.20-rc3] fix broken retval test in sr_block_ioctl Date: Tue, 2 Jan 2007 17:24:39 -0500 Message-ID: <200701021724.39613.liml@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from rtr.ca ([64.26.128.89]:2972 "EHLO mail.rtr.ca" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S964983AbXABWYi (ORCPT ); Tue, 2 Jan 2007 17:24:38 -0500 Content-Disposition: inline Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Tejun Heo , Jeff Garzik , IDE/ATA development list , linux-scsi@vger.kernel.org With recent kernels (and possibly much older ones, too), ioctl() calls for ATAPI devices never make it to the driver layers. The reason for this is a borked return code test in drivers/scsi/sr.c. This patch fixes it. Signed-off-by: Mark Lord --- --- old/drivers/scsi/sr.c 2006-11-29 16:57:37.000000000 -0500 +++ linux/drivers/scsi/sr.c 2007-01-02 16:40:33.000000000 -0500 @@ -468,7 +468,7 @@ } ret = cdrom_ioctl(file, &cd->cdi, inode, cmd, arg); - if (ret != ENOSYS) + if (ret != -ENOSYS) return ret; /*