From: Alan <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Mark Lord <liml@rtr.ca>, Linux IDE <linux-ide@vger.kernel.org>,
Tejun Heo <htejun@gmail.com>
Subject: Re: [PATCH] libata: add support for ATA_16 commands to ATAPI devices
Date: Wed, 3 Jan 2007 01:07:24 +0000 [thread overview]
Message-ID: <20070103010724.19b17522@localhost.localdomain> (raw)
In-Reply-To: <459AFDC2.6060900@garzik.org>
> I do not wish to completely eliminate the current behavior, which passes
> through all opcodes to the ATAPI device. You cannot guarantee that
> ATA_16 is never used for a vendor-reserved opcode, for example.
For 16 byte commands via SG_IO you know the command is 16 bytes long as
the command length is passed in hdr->cmd_len which becomes rq->cmd_len.
Is that not sufficient to avoid this ATA_16 test if you pass it on to the
required functions ?
Alan
next prev parent reply other threads:[~2007-01-03 0:57 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-03 0:39 [PATCH] libata: add support for ATA_16 commands to ATAPI devices Mark Lord
2007-01-03 0:44 ` Mark Lord
2007-01-03 0:50 ` [PATCH] " Jeff Garzik
2007-01-03 1:07 ` Alan [this message]
2007-01-03 1:06 ` Jeff Garzik
2007-01-03 5:44 ` Mark Lord
2007-01-03 11:34 ` Alan
2007-01-03 14:18 ` Mark Lord
2007-01-03 5:47 ` Mark Lord
2007-01-03 6:01 ` [PATCH] libata: add atapi_passthru=1 parameter Mark Lord
2007-01-03 6:24 ` [PATCH] RESPIN: " Mark Lord
2007-01-03 18:17 ` Mark Lord
2007-01-20 0:08 ` Jeff Garzik
2007-01-26 2:39 ` Mark Lord
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070103010724.19b17522@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=liml@rtr.ca \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).