* [2.6 patch] drivers/ata/: make 4 functions static
@ 2007-01-03 23:09 Adrian Bunk
2007-01-09 10:42 ` Jeff Garzik
0 siblings, 1 reply; 2+ messages in thread
From: Adrian Bunk @ 2007-01-03 23:09 UTC (permalink / raw)
To: jgarzik; +Cc: linux-ide, linux-kernel
This patch makes the following needlessly global functions static:
- libata-core.c: ata_qc_complete_internal()
- libata-scsi.c: ata_scsi_qc_new()
- libata-scsi.c: ata_dump_status()
- libata-scsi.c: ata_to_sense_error()
Signed-off-by: Adrian Bunk <bunk@stusta.de>
---
drivers/ata/libata-core.c | 2 +-
drivers/ata/libata-scsi.c | 12 ++++++------
2 files changed, 7 insertions(+), 7 deletions(-)
--- linux-2.6.20-rc2-mm1/drivers/ata/libata-core.c.old 2007-01-03 23:06:04.000000000 +0100
+++ linux-2.6.20-rc2-mm1/drivers/ata/libata-core.c 2007-01-03 23:06:12.000000000 +0100
@@ -1160,7 +1160,7 @@
ata_port_printk(ap, KERN_DEBUG, "%s: EXIT\n", __FUNCTION__);
}
-void ata_qc_complete_internal(struct ata_queued_cmd *qc)
+static void ata_qc_complete_internal(struct ata_queued_cmd *qc)
{
struct completion *waiting = qc->private_data;
--- linux-2.6.20-rc2-mm1/drivers/ata/libata-scsi.c.old 2007-01-03 23:06:35.000000000 +0100
+++ linux-2.6.20-rc2-mm1/drivers/ata/libata-scsi.c 2007-01-03 23:07:52.000000000 +0100
@@ -397,9 +397,9 @@
* RETURNS:
* Command allocated, or %NULL if none available.
*/
-struct ata_queued_cmd *ata_scsi_qc_new(struct ata_device *dev,
- struct scsi_cmnd *cmd,
- void (*done)(struct scsi_cmnd *))
+static struct ata_queued_cmd *ata_scsi_qc_new(struct ata_device *dev,
+ struct scsi_cmnd *cmd,
+ void (*done)(struct scsi_cmnd *))
{
struct ata_queued_cmd *qc;
@@ -435,7 +435,7 @@
* LOCKING:
* inherited from caller
*/
-void ata_dump_status(unsigned id, struct ata_taskfile *tf)
+static void ata_dump_status(unsigned id, struct ata_taskfile *tf)
{
u8 stat = tf->command, err = tf->feature;
@@ -610,8 +610,8 @@
* LOCKING:
* spin_lock_irqsave(host lock)
*/
-void ata_to_sense_error(unsigned id, u8 drv_stat, u8 drv_err, u8 *sk, u8 *asc,
- u8 *ascq, int verbose)
+static void ata_to_sense_error(unsigned id, u8 drv_stat, u8 drv_err, u8 *sk,
+ u8 *asc, u8 *ascq, int verbose)
{
int i;
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [2.6 patch] drivers/ata/: make 4 functions static
2007-01-03 23:09 [2.6 patch] drivers/ata/: make 4 functions static Adrian Bunk
@ 2007-01-09 10:42 ` Jeff Garzik
0 siblings, 0 replies; 2+ messages in thread
From: Jeff Garzik @ 2007-01-09 10:42 UTC (permalink / raw)
To: Adrian Bunk; +Cc: linux-ide, linux-kernel
Adrian Bunk wrote:
> This patch makes the following needlessly global functions static:
> - libata-core.c: ata_qc_complete_internal()
> - libata-scsi.c: ata_scsi_qc_new()
> - libata-scsi.c: ata_dump_status()
> - libata-scsi.c: ata_to_sense_error()
>
> Signed-off-by: Adrian Bunk <bunk@stusta.de>
applied
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2007-01-09 10:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2007-01-03 23:09 [2.6 patch] drivers/ata/: make 4 functions static Adrian Bunk
2007-01-09 10:42 ` Jeff Garzik
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).