From: Alan <alan@lxorguk.ukuu.org.uk>
To: Jeff Garzik <jeff@garzik.org>
Cc: Uwe Koziolek <uwe.koziolek@gmx.net>,
"linux.ide" <linux-ide@vger.kernel.org>,
Sven Ladegast <sven@linux4geeks.de>
Subject: Re: [PATCH 2.6.20-rc3-mm1 2/2] libata: SiS 180 pata/sata support
Date: Mon, 8 Jan 2007 10:28:09 +0000 [thread overview]
Message-ID: <20070108102809.512b4409@localhost.localdomain> (raw)
In-Reply-To: <45A19F67.6050909@garzik.org>
> If the shared code is tiny, just create a header file and #include it
> (sata_promise and sata_sx4 do this). Otherwise, create a shared library
> module.
pata_sis is both the SiS driver and the shared library. What needs fixing
IMHO is the Kconfig so that the user isn't aware of this. Then all the
CONFIG ifdef stuff goes away too.
Alan
next prev parent reply other threads:[~2007-01-08 10:17 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-08 1:33 [PATCH 2.6.20-rc3-mm1 2/2] libata: SiS 180 pata/sata support Jeff Garzik
2007-01-08 10:28 ` Alan [this message]
2007-01-08 11:44 ` Jeff Garzik
2007-01-08 12:51 ` Alan
2007-01-08 12:50 ` Jeff Garzik
2007-01-08 15:30 ` Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070108102809.512b4409@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=sven@linux4geeks.de \
--cc=uwe.koziolek@gmx.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).