From: Alan <alan@lxorguk.ukuu.org.uk>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: Linux IDE <linux-ide@vger.kernel.org>
Subject: Re: hwif->rw_disk() method
Date: Fri, 12 Jan 2007 10:27:00 +0000 [thread overview]
Message-ID: <20070112102700.3492bbb5@localhost.localdomain> (raw)
In-Reply-To: <45A63DEF.3010604@ru.mvista.com>
> BTW, I've looked at the clock turnaround code both in drivers/ide/hpt366.c
> and drivers/ata/pata_hpt3x2n.c and compared it to the HighPoint driver and I'm
> dazed and confused (again?): contrary to what HighPoint does (I'm not sure
Thats how I usually feel after looking at highpoints driver code.
> ATA_TFLAG_WRITE indicates a write transfer (host-to-device) while
> hpt3x2n_use_dpll() contrarywise expects the read transfer indication. Comments?
That looks like a bug. The code seems to get the DPLL choice right but
then the caller as you say is incorrect.
Will fix
prev parent reply other threads:[~2007-01-12 10:15 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-10 16:30 hwif->rw_disk() method Sergei Shtylyov
2007-01-10 17:10 ` Alan
2007-01-10 17:05 ` Sergei Shtylyov
2007-01-10 21:47 ` Bartlomiej Zolnierkiewicz
2007-01-11 13:38 ` Sergei Shtylyov
2007-01-12 10:27 ` Alan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070112102700.3492bbb5@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox