From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Subject: Re: [PATCH 3/4] libata-sff.c: add another IRQ calls Date: Tue, 16 Jan 2007 12:04:50 +0000 Message-ID: <20070116120450.1bb44ebb@localhost.localdomain> References: <200701161046.l0GAkE5u029367@toshiba.co.jp> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:51144 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751027AbXAPL6D (ORCPT ); Tue, 16 Jan 2007 06:58:03 -0500 In-Reply-To: <200701161046.l0GAkE5u029367@toshiba.co.jp> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Akira Iguchi Cc: linux-ide@vger.kernel.org, linuxppc-dev@ozlabs.org, kou.ishizaki@toshiba.co.jp, benh@kernel.crashing.org, arnd@arndb.de, paulus@samba.org, linas@austin.ibm.com, jeff@garzik.org On Tue, 16 Jan 2007 19:46:23 +0900 Akira Iguchi wrote: > When enabling IRQ, ap->ops->irq_on is checked. > Because most drivers can use ata_irq_on() as is, this > patch allows ap->ops->irq_on to be NULL. > If it is NULL, ata_irq_on() are used. I believe you can now remove the if(ap->ioaddr.ctl_addr) check as any device lacking a ctl_addr can now provide an irq_on() method using your changes. You've fixed the FIXME