From: Alan <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jgarzik@pobox.com>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: fix compile warning caused by ignoring __must_check results
Date: Mon, 22 Jan 2007 11:29:45 +0000 [thread overview]
Message-ID: <20070122112945.772a1c40@localhost.localdomain> (raw)
In-Reply-To: <20070120052329.GB24749@htj.dyndns.org>
On Sat, 20 Jan 2007 14:23:29 +0900
Tejun Heo <htejun@gmail.com> wrote:
> Fix compile warnings in pata_cs5530, sata_inic162x and sata_nv which
> are caused by throwing away return values marked with __must_check.
>
> Signed-off-by: Tejun Heo <htejun@gmail.com>
NAK NAK NAK NAK NAK NAK
As was previously discussed the bug is the bogus __must_check on
pci_set_mwi. That __must_check should be removed and that was also the
decision before but nothing happened. Please therefore get the pci header
fixed.
> pci_set_master(cs5530_0);
> - pci_set_mwi(cs5530_0);
> + rc = pci_set_mwi(cs5530_0);
> + if (rc)
> + dev_printk(KERN_WARNING, &cs5530_0->dev,
> + "WARNING: failed to set MWI\n");
Please drop this patch. Users don't need to scared by this bogus message.
Alan
next prev parent reply other threads:[~2007-01-22 11:18 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-20 5:23 [PATCH] libata: fix compile warning caused by ignoring __must_check results Tejun Heo
2007-01-22 11:29 ` Alan [this message]
2007-01-22 17:07 ` Tejun Heo
-- strict thread matches above, loose matches on Subject: below --
2007-01-20 6:45 Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070122112945.772a1c40@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).