From: Alan <alan@lxorguk.ukuu.org.uk>
To: Stefan Althoefer <as@janz.de>
Cc: linux-ide@vger.kernel.org
Subject: Re: problem with register_hw_with_fixup
Date: Tue, 23 Jan 2007 09:53:41 +0000 [thread overview]
Message-ID: <20070123095341.4017f2f0@localhost.localdomain> (raw)
In-Reply-To: <45B5CCA8.7010603@janz.de>
On Tue, 23 Jan 2007 09:51:52 +0100
Stefan Althoefer <as@janz.de> wrote:
> hi,
>
> I'm currently developing a ide driver for an embedded ARM device.
> The device hardware is somewhat wired, as all IDE access must
> be done 16bit, even the control bytes. I therefore need special
> access functions.
For new drivers you should really be looking at drivers/ata
> However, in probe_hwif_init_with_fixup() I find this sequence:
>
> -----%<-----------------
> int probe_hwif_init_with_fixup(ide_hwif_t *hwif, void (*fixup)(ide_hwif_t *hwif))
> {
> probe_hwif(hwif);
>
> if (fixup)
> fixup(hwif);
> -------------------------
>
> fixup() gets called after probe_hwif, hence my special function
> pointers will not be installed in time.
fixup is intended for doing drive level fixups and was added fairly
recently to deal with things like IT8212 in RAID mode and some PCMCIA
decode problems which run after the probe.
There isn't a good way to handle this with the old IDE layer. PMac does
it by walking the hwif array itself (without any proper locking). Adding
the call you need might be a good idea, but moving fixup will break
things.
Alan
prev parent reply other threads:[~2007-01-23 9:42 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-23 8:51 problem with register_hw_with_fixup Stefan Althoefer
2007-01-23 9:53 ` Alan [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070123095341.4017f2f0@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=as@janz.de \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).