From: Tejun Heo <htejun@gmail.com>
To: Jeff Garzik <jgarzik@pobox.com>
Cc: linux-ide@vger.kernel.org, j.taimr@chello.nl
Subject: [PATCH] sata_via: style clean up, no indirect method call in LLD
Date: Fri, 26 Jan 2007 14:57:31 +0900 [thread overview]
Message-ID: <20070126055731.GF8606@htj.dyndns.org> (raw)
In-Reply-To: <45B92E07.2040904@pobox.com>
Call ata_bmdma_irq_clear() directly instead of through
ap->ops->irq_clear() according to libata style guideline.
Signed-off-by: Tejun Heo <htejun@gmail.com>
diff --git a/drivers/ata/sata_via.c b/drivers/ata/sata_via.c
index 55b0123..d3d5c0d 100644
--- a/drivers/ata/sata_via.c
+++ b/drivers/ata/sata_via.c
@@ -211,7 +211,7 @@ static void svia_noop_freeze(struct ata_port *ap)
* certain way. Leave it alone and just clear pending IRQ.
*/
ata_chk_status(ap);
- ap->ops->irq_clear(ap);
+ ata_bmdma_irq_clear(ap);
}
/**
next prev parent reply other threads:[~2007-01-26 5:57 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-25 11:46 [PATCH] sata_via: don't diddle with ATA_NIEN in ->freeze Tejun Heo
2007-01-25 12:32 ` Alan
2007-01-25 22:24 ` Jeff Garzik
2007-01-26 5:57 ` Tejun Heo [this message]
2007-01-26 22:24 ` [PATCH] sata_via: style clean up, no indirect method call in LLD Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070126055731.GF8606@htj.dyndns.org \
--to=htejun@gmail.com \
--cc=j.taimr@chello.nl \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).