From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Subject: Re: [PATCH] libata: add a dummy set_mode() in pata_pcmcia Date: Sun, 28 Jan 2007 12:51:48 +0000 Message-ID: <20070128125148.2dfc1973@localhost.localdomain> References: <200701281134.02218.arnd@arndb.de> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:43509 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1751927AbXA1Mkf (ORCPT ); Sun, 28 Jan 2007 07:40:35 -0500 In-Reply-To: <200701281134.02218.arnd@arndb.de> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Arnd Bergmann Cc: jgarzik@pobox.com, wkl@informatik.uni-kiel.de, linux-ide@vger.kernel.org, linux-kernel@vger.kernel.org On Sun, 28 Jan 2007 11:34:01 +0100 Arnd Bergmann wrote: > CompactFlash cards in a passive PCMCIA adapter don't seem > to like the ATA_CMD_SET_FEATURES command, which causes > libata device probing to fail. > > Since PCMCIA only allows PIO mode 0 anyway, there is no > point in ever setting a higher speed. Adding the dummy > function seems to do the right thing. > > Signed-off-by: Arnd Bergmann NAK See the update in bug #7711