From: Alan <alan@lxorguk.ukuu.org.uk>
To: Sergei Shtylyov <sshtylyov@ru.mvista.com>
Cc: linux-ide@vger.kernel.org, jgarzik@pobox.com, htejun@gmail.com
Subject: Re: [RFC] libata IORDY handling
Date: Mon, 29 Jan 2007 13:34:23 +0000 [thread overview]
Message-ID: <20070129133423.75aa208e@localhost.localdomain> (raw)
In-Reply-To: <45BCEA03.8070901@ru.mvista.com>
> It's sad to say but there's another bug in this function (even a
> regression from drivers/ide/pci/siimage.c) -- the 16-bit IORDY is not enabled
> when setting PIO mode (there's code that twiddles IORDY enable but that's
> actually only for *taskfile* accesses, 16-bit IORDY is controlled by the same
> PCI config. registers 80h/84h that enable DMA/UDMA transfer on SiI 680).
Fixed - also fixed clearing the bits when going into PIO mode from DMA,
which fixes a potential DMA changedown bug.
Also redone the iordy stuff as your emails reminded me that it needed
finishing off and sorting out.
Alan
next prev parent reply other threads:[~2007-01-29 13:22 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-28 17:24 [PATCH] pata_sil680: PIO1 taskfile transfers oveclocking fix Sergei Shtylyov
2007-01-28 18:22 ` [RFC] libata IORDY handling Sergei Shtylyov
2007-01-28 19:03 ` Alan
2007-01-28 19:00 ` Sergei Shtylyov
2007-01-29 13:34 ` Alan [this message]
2007-01-29 14:28 ` Sergei Shtylyov
2007-01-29 15:45 ` Alan
2007-01-28 18:41 ` [PATCH] pata_sil680: PIO1 taskfile transfers oveclocking fix Alan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070129133423.75aa208e@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jgarzik@pobox.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).