From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alan Subject: Re: [PATCH] scsi_lib.c: continue after MEDIUM_ERROR Date: Wed, 31 Jan 2007 15:23:01 +0000 Message-ID: <20070131152301.19a8a5ac@localhost.localdomain> References: <200701301947.08478.liml@rtr.ca> <1170206199.10890.13.camel@mulgrave.il.steeleye.com> <311601c90701301725n53d25a74g652b7ca3bfc64c56@mail.gmail.com> <45BFF3D6.9050605@rtr.ca> <45C00AEE.1090708@emc.com> <45C0B0DC.8030501@rtr.ca> Mime-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Return-path: Received: from outpipe-village-512-1.bc.nu ([81.2.110.250]:57566 "EHLO lxorguk.ukuu.org.uk" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S964976AbXAaPK5 (ORCPT ); Wed, 31 Jan 2007 10:10:57 -0500 In-Reply-To: <45C0B0DC.8030501@rtr.ca> Sender: linux-ide-owner@vger.kernel.org List-Id: linux-ide@vger.kernel.org To: Mark Lord Cc: Ric Wheeler , "Eric D. Mudama" , James Bottomley , linux-kernel@vger.kernel.org, IDE/ATA development list , linux-scsi , dougg@torque.net > When libata reports a MEDIUM_ERROR to us, we *know* it's non-recoverable, > as the drive itself has already done internal retries (libata uses the > "with retry" ATA opcodes for this). This depends on the firmware. Some of the "raid firmware" drives don't appear to do retries in firmware. > But meanwhile, we still have the original issue too, where a single stray > bad sector can blow a system out of the water, because the mid-layer > currently aborts everything after it from a large merged request. > > Thus the original patch from this thread. :) Agreed