From: Alan <alan@lxorguk.ukuu.org.uk>
To: linux-ide@vger.kernel.org, bzolnier@google.com
Subject: [PATCH] ide-floppy: Fix unformatted media crash
Date: Wed, 31 Jan 2007 17:41:23 +0000 [thread overview]
Message-ID: <20070131174123.17aba9d1@localhost.localdomain> (raw)
A ZIP or similar with unformatted media will cause crashes when attempts
are made to read/write it in some cases. This is because bs_factor is
zero and we divide by it causing an oops.
As the size of a non-accessible/non-existant media is really a bit of a
zen question it doesn't matter if non-existant media is 512 bytes per
sector or zero. Setting it to 1 causes us to generate 512 bytes/sector
accesses and error properly.
Signed-off-by: Alan Cox <alan@redhat.com>
Based on a fix found lurking in an ancient bugzilla entry since about 2004 (ugghhh)
diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc6-mm3/drivers/ide/ide-floppy.c linux-2.6.20-rc6-mm3/drivers/ide/ide-floppy.c
--- linux.vanilla-2.6.20-rc6-mm3/drivers/ide/ide-floppy.c 2007-01-31 14:20:40.000000000 +0000
+++ linux-2.6.20-rc6-mm3/drivers/ide/ide-floppy.c 2007-01-31 14:33:42.000000000 +0000
@@ -1434,7 +1434,8 @@
drive->bios_cyl = 0;
drive->bios_head = drive->bios_sect = 0;
- floppy->blocks = floppy->bs_factor = 0;
+ floppy->blocks = 0;
+ floppy->bs_factor = 1;
set_capacity(floppy->disk, 0);
idefloppy_create_read_capacity_cmd(&pc);
next reply other threads:[~2007-01-31 17:29 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-01-31 17:41 Alan [this message]
[not found] ` <58cb370e0702021351j57c3b559v53741f09acab0b8b@mail.gmail.com>
2007-02-02 22:05 ` [PATCH] ide-floppy: Fix unformatted media crash Bartlomiej Zolnierkiewicz
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070131174123.17aba9d1@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=bzolnier@google.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).