From: Alan <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>, linux-ide@vger.kernel.org
Subject: Re: [PATCH] libata: reduce ATA command timeout to 7secs
Date: Fri, 2 Feb 2007 10:08:56 +0000 [thread overview]
Message-ID: <20070202100856.706bd1e8@localhost.localdomain> (raw)
In-Reply-To: <20070202063748.GC1625@htj.dyndns.org>
> Note that both normal commands and EH commands timeouts are adjusted
> to 7 secs, but cache flushses still have 30sec timeout. This is a
> side effect of the way sd makes use of sdev->timeout, but this is a
> good side effect in that ATA spec requires cache flushes are given
> longer timeout.
Our cache flush handling still appears to be questionable if not wrong.
Not sure how SCSI expects it to behave but for ATA we should call it
again on a fatal media error.
ACK to the patch itself.
next prev parent reply other threads:[~2007-02-02 9:56 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 6:37 [PATCH] libata: reduce ATA command timeout to 7secs Tejun Heo
2007-02-02 10:08 ` Alan [this message]
2007-02-02 11:49 ` Tejun Heo
2007-02-02 13:25 ` Ric Wheeler
2007-02-02 15:12 ` Tejun Heo
2007-02-02 15:39 ` Alan
2007-02-02 16:13 ` Mark Lord
2007-02-02 16:43 ` Eric D. Mudama
2007-02-02 18:47 ` Alan
2007-02-02 23:00 ` Eric D. Mudama
2007-02-03 23:34 ` Ric Wheeler
2007-02-03 4:31 ` Tejun Heo
2007-02-03 19:59 ` Alan
2007-02-03 19:50 ` Mark Lord
2007-02-02 16:12 ` Mark Lord
2007-02-03 4:45 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202100856.706bd1e8@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).