From: Alan <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
ahaas@airmail.net, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata_piix: fix pio/mwdma programming (for testing, don't apply)
Date: Fri, 2 Feb 2007 18:49:28 +0000 [thread overview]
Message-ID: <20070202184928.4229f99a@localhost.localdomain> (raw)
In-Reply-To: <45C369C5.5000201@gmail.com>
On Sat, 03 Feb 2007 01:41:41 +0900
Tejun Heo <htejun@gmail.com> wrote:
> > Actually, I think ata_timing_merge() should just be performed when
> > setting MWDMA mode... This should be the right thing to do in most cases
> > (however, this hardware has some complications in the form of only 2-bit
> > wide active/recovery counts and 2 fast timing bank select bits)...
>
> Yeap, that'll be nice. Dunno whether modifying piix/ata_piix too much
> would be a good idea tho considering the wide usage.
If I remember rightly the 2bits is ok because you can set the bit to say
that timings are for DMA only, the device then uses slower than PIO0 for
all other cycles.
> In both mwdma and pio cases, they're just turning off UDMA. Don't know
> whether it's actually necessary but still afraid to change it unless
> there is a good reason.
The tuning manual I have does it, so I do it 8)
Alan
next prev parent reply other threads:[~2007-02-02 18:37 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 15:18 [PATCH] ata_piix: fix pio/mwdma programming (for testing, don't apply) Tejun Heo
2007-02-02 15:34 ` Sergei Shtylyov
2007-02-02 16:38 ` Jeff Garzik
2007-02-02 16:57 ` Mark Lord
2007-02-02 18:34 ` Sergei Shtylyov
2007-02-02 16:41 ` Tejun Heo
2007-02-02 18:49 ` Alan [this message]
2007-02-02 19:04 ` Sergei Shtylyov
2007-02-02 17:42 ` Alan
2007-02-03 1:40 ` Tejun Heo
2007-02-03 20:04 ` Alan
2007-02-04 2:47 ` Tejun Heo
2007-02-02 21:14 ` Art Haas
2007-02-03 2:09 ` Tejun Heo
2007-02-03 14:35 ` Art Haas
2007-02-03 19:47 ` Mark Lord
2007-02-06 9:11 ` Tejun Heo
2007-02-06 16:33 ` Art Haas
2007-02-07 2:53 ` Tejun Heo
2007-02-07 19:35 ` Art Haas
2007-02-07 19:51 ` Mark Lord
2007-02-07 20:37 ` [PATCH] libata: clear TF before IDENTIFYing Tejun Heo
2007-02-08 14:56 ` Mark Lord
2007-02-13 19:38 ` Art Haas
2007-02-15 23:08 ` Jeff Garzik
2007-04-30 18:29 ` [PATCH] Fix pio/mwdma programming on ata_piix.c Art Haas
2007-05-01 3:02 ` Tejun Heo
2007-05-24 19:59 ` Art Haas
2007-05-24 20:55 ` Jeff Garzik
2007-05-24 21:03 ` Tejun Heo
2007-05-25 17:16 ` [PATCH] ata_piix: fix pio/mwdma programming Tejun Heo
2007-05-25 18:05 ` Alan Cox
2007-05-28 13:02 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070202184928.4229f99a@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=ahaas@airmail.net \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).