From: Alan <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: ahaas@airmail.net, linux-ide@vger.kernel.org
Subject: Re: [PATCH] ata_piix: fix pio/mwdma programming (for testing, don't apply)
Date: Sat, 3 Feb 2007 20:04:28 +0000 [thread overview]
Message-ID: <20070203200428.4a7a5682@localhost.localdomain> (raw)
In-Reply-To: <45C3E7F0.6000506@gmail.com>
> > Yep and if the BIOS programmed the slave into DMA that might not be ideal.
>
> How so? The bit will be programmed by set_dmamode() right after
> set_piomode() is complete.
IFF we also put the device into a DMA mode. A blacklisted device would be
wrong.
> See the difference? Smart one liners are dangerous. ?* is _much_
> better than cryptic arithmetic.
Agreed
>
> >> * MWDMA mode programming cleared udma_mask even when the controller
> >> doesn't support UDMA. This doesn't matter for your case.
> >
> > Or on the actual hardware.
>
> I was trying to make it more consistent with pio counterpart. We can
> remove if() from set_piomode too. Let's just keep things in sync
> between stuff including ide piix driver.
The one you must not touch is the UDMA register rather than added UDMA
bits in older registers.
Alan
next prev parent reply other threads:[~2007-02-03 19:52 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-02 15:18 [PATCH] ata_piix: fix pio/mwdma programming (for testing, don't apply) Tejun Heo
2007-02-02 15:34 ` Sergei Shtylyov
2007-02-02 16:38 ` Jeff Garzik
2007-02-02 16:57 ` Mark Lord
2007-02-02 18:34 ` Sergei Shtylyov
2007-02-02 16:41 ` Tejun Heo
2007-02-02 18:49 ` Alan
2007-02-02 19:04 ` Sergei Shtylyov
2007-02-02 17:42 ` Alan
2007-02-03 1:40 ` Tejun Heo
2007-02-03 20:04 ` Alan [this message]
2007-02-04 2:47 ` Tejun Heo
2007-02-02 21:14 ` Art Haas
2007-02-03 2:09 ` Tejun Heo
2007-02-03 14:35 ` Art Haas
2007-02-03 19:47 ` Mark Lord
2007-02-06 9:11 ` Tejun Heo
2007-02-06 16:33 ` Art Haas
2007-02-07 2:53 ` Tejun Heo
2007-02-07 19:35 ` Art Haas
2007-02-07 19:51 ` Mark Lord
2007-02-07 20:37 ` [PATCH] libata: clear TF before IDENTIFYing Tejun Heo
2007-02-08 14:56 ` Mark Lord
2007-02-13 19:38 ` Art Haas
2007-02-15 23:08 ` Jeff Garzik
2007-04-30 18:29 ` [PATCH] Fix pio/mwdma programming on ata_piix.c Art Haas
2007-05-01 3:02 ` Tejun Heo
2007-05-24 19:59 ` Art Haas
2007-05-24 20:55 ` Jeff Garzik
2007-05-24 21:03 ` Tejun Heo
2007-05-25 17:16 ` [PATCH] ata_piix: fix pio/mwdma programming Tejun Heo
2007-05-25 18:05 ` Alan Cox
2007-05-28 13:02 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070203200428.4a7a5682@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=ahaas@airmail.net \
--cc=htejun@gmail.com \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).