From: Alan <alan@lxorguk.ukuu.org.uk>
To: Tejun Heo <htejun@gmail.com>
Cc: Jeff Garzik <jeff@garzik.org>,
linux-ide@vger.kernel.org, stable@kernel.org
Subject: Re: [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check
Date: Mon, 5 Feb 2007 10:57:44 +0000 [thread overview]
Message-ID: <20070205105744.6f22fc7d@localhost.localdomain> (raw)
In-Reply-To: <20070205074535.GE1625@htj.dyndns.org>
On Mon, 5 Feb 2007 16:45:35 +0900
Tejun Heo <htejun@gmail.com> wrote:
> The 80c wire bit is bit 13, not 14. Bit 14 is always 1 if word93 is
> implemented. This increases the chance of incorrect wire detection
> especially because host side cable detection is often unreliable and
> we sometimes soley depend on drive side cable detection. Fix it.
NAK to the fix but not the report
We must check bits 15 and 14 to know if bit 13 is valid. The old code is
wrong (follows the old IDE bits) but your change is probably no better as
you remove the needed validity check.
if ((dev_id[93] & 0xC000) == 0x4000) && (dev_id[93] & 0x2000))
return 0;
Alan
next prev parent reply other threads:[~2007-02-05 10:46 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 7:45 [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check Tejun Heo
2007-02-05 10:57 ` Alan [this message]
2007-02-05 12:41 ` [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 2 Tejun Heo
2007-02-05 13:27 ` Alan
2007-02-05 14:21 ` [PATCH libata-dev#upstream-fixes] libata: fix drive side 80c cable check, take 3 Tejun Heo
2007-02-05 14:36 ` Alan
2007-02-15 23:08 ` Jeff Garzik
2007-07-12 18:40 ` Sergei Shtylyov
2007-07-12 18:50 ` Sergei Shtylyov
2007-07-13 4:12 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070205105744.6f22fc7d@localhost.localdomain \
--to=alan@lxorguk.ukuu.org.uk \
--cc=htejun@gmail.com \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
--cc=stable@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).