From: Andrew Morton <akpm@linux-foundation.org>
To: Alan <alan@lxorguk.ukuu.org.uk>
Cc: linux-ide@vger.kernel.org, jeff@garzik.org
Subject: Re: [PATCH] libata: Early CFA adapters are not required to support mode setting
Date: Mon, 5 Feb 2007 14:52:20 -0800 [thread overview]
Message-ID: <20070205145220.4eb3269b.akpm@linux-foundation.org> (raw)
In-Reply-To: <20070205162830.5f9cff4a@localhost.localdomain>
On Mon, 5 Feb 2007 16:28:30 +0000
Alan <alan@lxorguk.ukuu.org.uk> wrote:
> If we are doing a PIO setup for a CFA card and it blows up with a device
> error then assume it is an older CFA card which doesn't support this
> rather than failing the device out of existance.
>
> Stands seperate to the quieting patch but that is obviously useful with
> this change.
>
> Signed-off-by: Alan Cox <alan@redhat.com>
>
> diff -u --new-file --recursive --exclude-from /usr/src/exclude linux.vanilla-2.6.20-rc6-mm3/drivers/ata/libata-core.c linux-2.6.20-rc6-mm3/drivers/ata/libata-core.c
> --- linux.vanilla-2.6.20-rc6-mm3/drivers/ata/libata-core.c 2007-01-31 14:20:39.000000000 +0000
> +++ linux-2.6.20-rc6-mm3/drivers/ata/libata-core.c 2007-02-01 16:14:01.000000000 +0000
> @@ -2404,6 +2460,10 @@
> dev->flags |= ATA_DFLAG_PIO;
>
> err_mask = ata_dev_set_xfermode(dev);
> + /* Old CFA may refuse this command, which is just fine */
> + if (dev->xfer_shift == ATA_SHIFT_PIO && ata_id_is_cfa(dev->id))
> + err_mask &= ~AC_ERR_DEV;
> +
> if (err_mask) {
> ata_dev_printk(dev, KERN_ERR, "failed to set xfermode "
> "(err_mask=0x%x)\n", err_mask);
This hunk is already in
libata-fix-hopefully-all-the-remaining-problems-with.patch. Should I drop
libata-fix-hopefully-all-the-remaining-problems-with.patch?
If its presence can affect the validity of testing these four patches then
perhaps yes..
next prev parent reply other threads:[~2007-02-05 22:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2007-02-05 16:28 [PATCH] libata: Early CFA adapters are not required to support mode setting Alan
2007-02-05 22:52 ` Andrew Morton [this message]
2007-02-05 23:11 ` Alan
2007-02-05 23:14 ` Andrew Morton
2007-02-07 1:04 ` Jeff Garzik
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20070205145220.4eb3269b.akpm@linux-foundation.org \
--to=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=jeff@garzik.org \
--cc=linux-ide@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).